Portals 3435-2 only run sonarcloud scan on merge, not PR #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and environment has been set up. This will avoid failing workflows
…orepo, to denote this workflow doesn't run on PR
jay-hodgson
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all PR workflows are marked as failing because the sonarcloud scan cannot access the main repo's secrets when run from a fork. The sage-monorepo solves this by creating two scan workflows, one for merge and one for PR. The latter runs in an environment that allows forks to access the sonar cloud token.
This PR removes the current scan workflow from running on PR, which will prevent all of the current PR workflows from failing. The scan-on-PR functionality will be restored once the correct github environment is set up to allow scanning workflows from forked PRs.