Features/RemoteConfig #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achintkalra
reviewed
Jan 31, 2017
| Task fetchTask = mFirebaseRemoteConfig.fetch(cacheExpirationSeconds.longValue()); | ||
| fetchTask.addOnCompleteListener(new OnCompleteListener<Void>() { | ||
| @Override | ||
| public void onComplete(@NonNull Task<Void> task) { |
There was a problem hiding this comment.
If using Java 8, consider using lambda
There was a problem hiding this comment.
@achintkalra thanks Achint, This code will run in Android, will that make any difference?
achintkalra
reviewed
Jan 31, 2017
| try { | ||
| promise.resolve(mFirebaseRemoteConfig.getInfo().getConfigSettings().isDeveloperModeEnabled()); | ||
| } catch (Exception e) { | ||
| e.printStackTrace(); |
achintkalra
reviewed
Jan 31, 2017
| try { | ||
| Set<String> value; | ||
|
|
||
| if (namespace != null && !namespace.isEmpty()) { |
There was a problem hiding this comment.
Consider using Apache's StringUtils.isBlank
nkashyap
commented
Feb 3, 2017
| @@ -0,0 +1,232 @@ | |||
| // | |||
| // FirestackRemoteConfig.m | |||
| // Firestack | |||
There was a problem hiding this comment.
@Salakar @Ehesp @chrisbianca Hello guys, please can you help me with objective-c code.
There was a problem hiding this comment.
I managed to put some objective-c code together using example, but it is throwing exceptions.
nkashyap
commented
Feb 3, 2017
| LIBRARY_SEARCH_PATHS = "$(inherited)"; | ||
| MACH_O_TYPE = staticlib; | ||
| OTHER_LDFLAGS = "$(inherited)"; | ||
| PRODUCT_NAME = Firestack; | ||
| SKIP_INSTALL = YES; | ||
| SWIFT_OBJC_BRIDGING_HEADER = "Firestack-Bridging-Header.h"; | ||
| SWIFT_VERSION = 3.0; |
nkashyap
commented
Feb 3, 2017
| LIBRARY_SEARCH_PATHS = "$(inherited)"; | ||
| MACH_O_TYPE = staticlib; | ||
| ONLY_ACTIVE_ARCH = YES; | ||
| OTHER_LDFLAGS = "$(inherited)"; | ||
| PRODUCT_NAME = Firestack; | ||
| SKIP_INSTALL = YES; | ||
| SWIFT_OBJC_BRIDGING_HEADER = "Firestack-Bridging-Header.h"; | ||
| SWIFT_OPTIMIZATION_LEVEL = "-Onone"; | ||
| SWIFT_VERSION = 3.0; |
nkashyap
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemoteConfig
This PR implements FIrebase remote-config api for both Android & IOS
TODO checklist