Super-Linter configure PYTHON_RUFF_FORMAT#1100
Draft
URAYUSHJAIN wants to merge 5 commits intoSalamLang:mainfrom
Draft
Super-Linter configure PYTHON_RUFF_FORMAT#1100URAYUSHJAIN wants to merge 5 commits intoSalamLang:mainfrom
PYTHON_RUFF_FORMAT#1100URAYUSHJAIN wants to merge 5 commits intoSalamLang:mainfrom
Conversation
- Added contextually relevant emojis to all headings in CONTRIBUTING.md - Emojis include: 🤝 for main heading, 🌟 for ways to contribute, 🚀 for getting started - Added 📝 for code style, 🛠️ for formatting tools, 🪝 for commit hooks, 💬 for feedback - Improves visual appeal and readability of the contributing guide Closes SalamLang#1094
- Created .jscpd.json config file to handle legitimate code patterns - Set higher threshold (50) and minLines (10) to reduce false positives - Ignored generated AST and utility function patterns that are intentionally similar - Excluded common C boilerplate patterns like create/destroy/json/log functions - Configured appropriate ignore patterns for header guards and null checks - Addresses duplicate code detection issues in Super-Linter workflow Closes SalamLang#1092
- Address reviewer feedback from @jbampton - Keep PR focused on single issue (SalamLang#1094 - emoji in contributing guide) - JSCPD configuration should be handled in separate PR for issue SalamLang#1092
- Added Ruff configuration in pyproject.toml with Black-compatible settings - Configured Ruff as primary Python formatter (line-length=88, double quotes) - Updated super-linter.yml to use Ruff instead of Black for consistency - Fixed Python linting issues: removed unused variables in generate_files.py - Fixed f-string escape sequence compatibility issue in update-build.py - All Python files now pass Ruff formatting and linting checks Ruff provides faster formatting and linting than Black while maintaining compatibility. Closes SalamLang#1080
github-actions
bot
added
documentation
jbampton
requested changes
Oct 2, 2025
Member
jbampton
left a comment
jbampton
left a comment
There was a problem hiding this comment.
Please remove the changes to the contributing guide
Member
|
github-actions
bot
removed
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a brief description of the changes introduced by this pull request.
Related Issue
If this pull request addresses or resolves an existing issue, please reference it here.
Proposed Changes
Outline the changes made in this pull request and explain their purpose.
Checklist
Additional Notes
Add any additional notes or context about this pull request.