Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL sanitizer #563

Merged
merged 8 commits into from
Jun 13, 2024
Merged

URL sanitizer #563

merged 8 commits into from
Jun 13, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Jun 10, 2024

Description

Please include a summary of the change and which is fixed.

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.73%. Comparing base (1fe14d1) to head (aa5b55e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
+ Coverage   90.72%   90.73%   +0.01%     
==========================================
  Files         129      129              
  Lines        4551     4556       +5     
  Branches      736      738       +2     
==========================================
+ Hits         4129     4134       +5     
  Misses        277      277              
  Partials      145      145              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: rollback after Samsung/CredData#144

@babenek babenek marked this pull request as ready for review June 11, 2024 07:37
@babenek babenek requested a review from a team as a code owner June 11, 2024 07:37
Copy link
Contributor

@kmnls kmnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

Copy link
Contributor

@kmnls kmnls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@babenek babenek merged commit f9b73b3 into Samsung:main Jun 13, 2024
28 checks passed
@babenek babenek deleted the auxiliary branch June 13, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants