Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Password pattern #653

Merged
merged 2 commits into from
Jan 24, 2025
Merged

SQL Password pattern #653

merged 2 commits into from
Jan 24, 2025

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Jan 11, 2025

Description

Please include a summary of the change and which is fixed.

TODO: after Samsung/CredData#187

  • Add SQL Password pattern
  • Added hidden layer to ml model
  • Build charset for LSTM with ASCII symbols during train.
  • Retrain with tuning dropout values for LSTM & Dense layers
  • update docs for new ml structure

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.28%. Comparing base (06c54e7) to head (fbba7fd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #653   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files         135      135           
  Lines        4937     4937           
  Branches      810      810           
=======================================
  Hits         4556     4556           
  Misses        242      242           
  Partials      139      139           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek
Copy link
Contributor Author

babenek commented Jan 21, 2025

AS IS TO BE
ml_model ml_model

@babenek babenek marked this pull request as ready for review January 21, 2025 11:09
@babenek babenek requested a review from a team as a code owner January 21, 2025 11:09
@babenek babenek marked this pull request as draft January 23, 2025 05:47
@babenek babenek requested a review from Dmitriy-NK January 23, 2025 08:04
@babenek babenek marked this pull request as ready for review January 23, 2025 09:13
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@babenek babenek merged commit add6156 into Samsung:main Jan 24, 2025
32 checks passed
@babenek babenek deleted the sqlpass branch January 24, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants