Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dummy candidate refactoring #665

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Dummy candidate refactoring #665

merged 1 commit into from
Jan 30, 2025

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Jan 29, 2025 •
edited
Loading

Description

Please include a summary of the change and which is fixed.

  • Add names for pseudo rules "PKCS12", "Java Key Storage", "Suspicious File Extension" with WEAK confidence
  • Refactoring file size check to skip a file less than 8 bytes
  • Move bruteforce list for JKS and PKCS12 into config
  • Version Up to 1.10.4

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek marked this pull request as ready for review January 29, 2025 20:32
@babenek babenek requested a review from a team as a code owner January 29, 2025 20:32
Dmitriy-NK
Dmitriy-NK approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@Dmitriy-NK Dmitriy-NK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@babenek babenek merged commit 0c8772a into Samsung:main Jan 30, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dmitriy-NK Dmitriy-NK Dmitriy-NK approved these changes

@VladSamsung VladSamsung VladSamsung approved these changes

@xDizzix xDizzix Awaiting requested review from xDizzix

@Yullia Yullia Awaiting requested review from Yullia

@iuriimet iuriimet Awaiting requested review from iuriimet

@meanrin meanrin Awaiting requested review from meanrin

@csh519 csh519 Awaiting requested review from csh519

@kmnls kmnls Awaiting requested review from kmnls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@babenek @Dmitriy-NK @VladSamsung