Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent extra line split for HTML scan #673

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Feb 11, 2025

Description

Please include a summary of the change and which is fixed.

  • Use TAB instead LF to add separators in some html tags
  • Fix Benchmark scores

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.52%. Comparing base (2a91be1) to head (ab1b581).

Files with missing lines Patch % Lines
credsweeper/file_handler/data_content_provider.py 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
+ Coverage   92.44%   92.52%   +0.07%     
==========================================
  Files         135      135              
  Lines        4990     4988       -2     
  Branches      822      822              
==========================================
+ Hits         4613     4615       +2     
+ Misses        228      226       -2     
+ Partials      149      147       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek babenek marked this pull request as ready for review February 11, 2025 10:32
@babenek babenek requested a review from a team as a code owner February 11, 2025 10:32
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@babenek babenek merged commit 9b5888e into Samsung:main Feb 13, 2025
29 checks passed
@babenek babenek deleted the htmlline branch February 13, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants