-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[github] Introduce Workflow build-circle-intp #14683
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments,
PTAL =)
# TODO enable retention-days, default is 90 | ||
# retention-days: 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you enable retention-days
now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For experiment with URL from comment, I will not use scheduled rebuild
- circle-interpreter don't need to be updated daily
- max is 90 days and I'll use that Artiface for now
- I don't have access key and the person, I don't know who, didn't approved the key request, to update comment for daily build download URL
This will introduce build-circle-intp Workflow to build and provide circle-interpreter as Workflow Artifact. ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]> Co-authored-by: Seungho Henry Park <[email protected]>
dffbc26
to
39a2319
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you
=)
This will introduce build-circle-intp Workflow to build and
provide circle-interpreter as Workflow Artifact.
ONE-DCO-1.0-Signed-off-by: SaeHie Park [email protected]