Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[github] Introduce Workflow build-circle-intp #14683

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

seanshpark
Copy link
Contributor

This will introduce build-circle-intp Workflow to build and
provide circle-interpreter as Workflow Artifact.

ONE-DCO-1.0-Signed-off-by: SaeHie Park [email protected]

@seanshpark
Copy link
Contributor Author

seanshpark commented Feb 17, 2025

@seanshpark seanshpark requested review from hseok-oh and a team and removed request for hseok-oh February 17, 2025 00:54
Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments,
PTAL =)

Comment on lines +90 to +91
# TODO enable retention-days, default is 90
# retention-days: 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you enable retention-days now?

Copy link
Contributor Author

@seanshpark seanshpark Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For experiment with URL from comment, I will not use scheduled rebuild

  • circle-interpreter don't need to be updated daily
  • max is 90 days and I'll use that Artiface for now
  • I don't have access key and the person, I don't know who, didn't approved the key request, to update comment for daily build download URL

ragmani
ragmani previously approved these changes Feb 17, 2025
This will introduce build-circle-intp Workflow to build and provide
circle-interpreter as Workflow Artifact.

ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]>
Co-authored-by: Seungho Henry Park <[email protected]>
Copy link
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you
=)

@seanshpark seanshpark merged commit 8db565e into Samsung:master Feb 17, 2025
3 checks passed
@seanshpark seanshpark deleted the gh_bld_cirintp branch February 17, 2025 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants