Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[circle-mlir/export] Introduce CircleExport #14729

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

seanshpark
Copy link
Contributor

This will introduce CircleExport to export MLIR graph to circle flatbuffer file.

This will introduce CircleExport to export MLIR graph to
circle flatbuffer file.

ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]>
@seanshpark
Copy link
Contributor Author

@seanshpark
Copy link
Contributor Author

seanshpark commented Feb 21, 2025

To reviewers: this change is quite huge unlike the others
but the code itself is almost the same from original mlir/lite/flatbuffer_export.cc file
with removal of codes that are not necessary as of now.

If we need to review with small amounts, feel free to leave a comment.

@seanshpark seanshpark requested a review from a team February 21, 2025 10:21
Copy link
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 (I guess that it has already been divided into small parts.)

Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
=)

@seanshpark seanshpark merged commit f1267a3 into Samsung:master Feb 24, 2025
5 checks passed
@seanshpark seanshpark deleted the cm_ex_cirexp branch February 24, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants