Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[circle-mlir/ext] Fix externals CMakeLists #14734

Merged
merged 1 commit into from
Feb 25, 2025
Merged

[circle-mlir/ext] Fix externals CMakeLists #14734

merged 1 commit into from
Feb 25, 2025

Conversation

seanshpark
Copy link
Contributor

@seanshpark seanshpark commented Feb 25, 2025 •
edited
Loading

This will fix externals/CMakeLists with missing folder variables.

@seanshpark
[circle-mlir/ext] Fix externals CMakeLists
1d006ec 
This will fix externsla/CMakeLists with missing folder variables.

ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]>
@seanshpark
Copy link
Contributor Author

@seanshpark seanshpark requested a review from a team February 25, 2025 00:37
zetwhite
zetwhite approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@zetwhite zetwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ragmani
ragmani approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit ceab7be into Samsung:master Feb 25, 2025
5 checks passed
@seanshpark seanshpark deleted the cm_ext_cmake branch February 25, 2025 04:06
shs-park
shs-park reviewed Feb 25, 2025
View reviewed changes
Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shs-park shs-park shs-park left review comments

@ragmani ragmani ragmani approved these changes

@zetwhite zetwhite zetwhite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seanshpark @ragmani @zetwhite @shs-park