[circle-mlir/dialect] Enable AddOp IR #14748
Merged
+121
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enable AddOp IR in dialect. ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]>
mhs4670go
reviewed
Feb 26, 2025
Comment on lines
+316
to
+317
| ins CIR_TensorOf<[F32, I32, I64]>:$lhs, | ||
| CIR_TensorOf<[F32, I32, I64]>:$rhs, |
There was a problem hiding this comment.
The reason why there's no Q8 or Q16 dtype here is because current circle-mlir focus on fake-quantized or float models?
There was a problem hiding this comment.
Yes...
But the actual reason is that quantize related codes are linked to TensorFlow that are too huge to import as of now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable AddOp IR in dialect.