[MediaController] Add new API to check Response request #5672
Conversation
Public API ChangedPlease follow the ACR process for the changed API below. Added: 1, Removed: 0, Changed: 0Added+ /// <since_tizen>12</since_tizen
+ System.Boolean Tizen.Multimedia.Remoting.Command::NeedToResponse()
|
| } | ||
|
|
||
| /// <summary> | ||
| /// Gets the status of response. |
There was a problem hiding this comment.
how it sounds suggests that it can change, like when Response is supplied it would be set to false then,
suggestion: "Indicates whether a response is expected for this command." or "Indicates if the command should be responded to" or shorter brief "Indicates if the response is needed."
There was a problem hiding this comment.
I'll change it to 'Indicates if the response is needed.'
| /// <summary> | ||
| /// Gets the status of response. | ||
| /// </summary> | ||
| /// <remarks>If false, the receiver should not response for the received command.</remarks> |
There was a problem hiding this comment.
| /// <remarks>If false, the receiver should not response for the received command.</remarks> | |
| /// <remarks>If false, the receiver should not respond to the received command.</remarks> |
| /// </summary> | ||
| /// <remarks>If false, the receiver should not response for the received command.</remarks> | ||
| /// <since_tizen> 12 </since_tizen> | ||
| public bool NeedToResponse => _requestId != null; |
There was a problem hiding this comment.
please change the name of this property, like "IsResponseNeeded", "ResponseNeeded", "NeedToRespond", it cannot be [to + noun]
There was a problem hiding this comment.
I'll change it to 'IsResponseNeeded'. But 'NeedToResponse' is already used in VD, so I'll keep it internal api only.
| @@ -90,6 +103,11 @@ internal void SetResponseInformation(string receiverId, string requestId) | |||
| /// <param name="bundle">The extra data.</param> | |||
There was a problem hiding this comment.
Could you change the description at line 99 (and for the next method)? Like "Sends command response to the client" or "Responds to the clients command"
Unfortunately we cannot change the name of the method, "Response" is a noun and method names should be verb (or centered around verb), so it should be Respond() or SendResponse()
There was a problem hiding this comment.
I'll change it to Responds to the clients command..
Public API ChangedPlease follow the ACR process for the changed API below. Added: 17, Removed: 0, Changed: 0Added+ /// <since_tizen>12</since_tizen
+ System.Boolean Tizen.Multimedia.Remoting.Command::IsResponseNeeded()
+ /// <since_tizen>none</since_tizen
+ System.Void Tizen.NUI.Scene3D.Model::Dispose(Tizen.NUI.DisposeTypes)
+ /// <since_tizen>10</since_tizen
+ Tizen.System.PowerLockStateChangedEventArgs
+ /// <since_tizen>none</since_tizen
+ Tizen.System.PowerLock Tizen.System.PowerLockStateChangedEventArgs::PowerLockType()
+ /// <since_tizen>none</since_tizen
+ Tizen.System.PowerLockState Tizen.System.PowerLockStateChangedEventArgs::PowerLockState()
+ /// <since_tizen>10</since_tizen
+ Tizen.System.PowerStateChangeRequestEventArgs
+ /// <since_tizen>none</since_tizen
+ System.Int32 Tizen.System.PowerStateChangeRequestEventArgs::Retval()
+ /// <since_tizen>none</since_tizen
+ Tizen.System.PowerState Tizen.System.PowerStateChangeRequestEventArgs::PowerState()
+ /// <since_tizen>10</since_tizen
+ Tizen.System.PowerStateWaitEventArgs
+ /// <since_tizen>none</since_tizen
+ System.UInt64 Tizen.System.PowerStateWaitEventArgs::WaitCallbackId()
+ /// <since_tizen>none</since_tizen
+ Tizen.System.PowerState Tizen.System.PowerStateWaitEventArgs::NextState()
+ /// <since_tizen>none</since_tizen
+ Tizen.System.PowerState Tizen.System.PowerStateWaitEventArgs::PrevState()
+ /// <since_tizen>none</since_tizen
+ Tizen.System.PowerTransitionReason Tizen.System.PowerStateWaitEventArgs::TransitionReason()
+ /// <since_tizen>10</since_tizen
+ Tizen.System.PowerTransientStateWaitEventArgs
+ /// <since_tizen>none</since_tizen
+ System.UInt64 Tizen.System.PowerTransientStateWaitEventArgs::WaitCallbackId()
+ /// <since_tizen>none</since_tizen
+ Tizen.System.PowerTransientState Tizen.System.PowerTransientStateWaitEventArgs::TransientState()
+ /// <since_tizen>none</since_tizen
+ Tizen.System.PowerTransitionReason Tizen.System.PowerTransientStateWaitEventArgs::TransitionReason()
Internal API ChangedAdded: 110, Removed: 5, Changed: 0 |
Public API ChangedPlease follow the ACR process for the changed API below. Added: 1, Removed: 0, Changed: 0Added+ /// <since_tizen>12</since_tizen
+ System.Boolean Tizen.Multimedia.Remoting.Command::IsResponseNeeded()
Internal API ChangedAdded: 1, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.Multimedia.Remoting.Command::NeedToResponse()
|
* [MediaController] Add new API to check Response request
Description of Change
Add new API to check whether sender ask Respose for command or not.
Fix crash issue when request_id is null.
API Changes