[ACR-564][NUI] deprecate unused API #5821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsug-song
changed the title
Public API ChangedPlease follow the ACR process for the changed API below. Internal API ChangedAdded: 0, Removed: 0, Changed: 29Changed/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
static System.Double ElmSharp.Elementary::GetScale()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
static System.Double ElmSharp.Elementary::GetSystemScrollFriction()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
static System.String ElmSharp.Elementary::GetProfile()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
static System.Void ElmSharp.Elementary::ReloadConfig()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
static System.Void ElmSharp.Elementary::SetScale(System.Double)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
static System.Void ElmSharp.Elementary::SetSystemScrollFriction(System.Double)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
static System.Void ElmSharp.Elementary::ThemeOverlay()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Double ElmSharp.ElmScrollConfig::BringInScrollFriction()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void ElmSharp.EvasImage::SetNativeSurface(System.IntPtr)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void ElmSharp.EvasObjectEvent::.ctor(ElmSharp.EvasObject,System.IntPtr,ElmSharp.EvasObjectCallbackType)
/// <since_tizen>none</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void ElmSharp.EvasObjectEvent`1::.ctor(ElmSharp.EvasObject,System.IntPtr,ElmSharp.EvasObjectCallbackType,ElmSharp.EvasObjectEvent`1/SmartEventInfoParser<TEventArgs>)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Boolean ElmSharp.GenGridItem::IsUseEngineCursor()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.String ElmSharp.GenGridItem::Cursor()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.String ElmSharp.GenGridItem::CursorStyle()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Boolean ElmSharp.GenListItem::IsUseEngineCursor()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.String ElmSharp.GenListItem::Cursor()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.String ElmSharp.GenListItem::CursorStyle()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
ElmSharp.KeyGrabMode
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void ElmSharp.SmartEvent::.ctor(ElmSharp.EvasObject,System.IntPtr,System.String)
/// <since_tizen>none</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void ElmSharp.SmartEvent`1::.ctor(ElmSharp.EvasObject,System.IntPtr,System.String,ElmSharp.SmartEvent`1/SmartEventInfoParser<TEventArgs>)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Boolean ElmSharp.Toolbar::IsHorizontal()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Boolean ElmSharp.Window::Iconified()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Boolean ElmSharp.Window::DeleteAuxiliaryHint(System.Int32)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Boolean ElmSharp.Window::SetAuxiliaryHintValue(System.Int32,System.String)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Int32 ElmSharp.Window::AddAuxiliaryHint(System.String,System.String)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Int32 ElmSharp.Window::GetAuxiliaryHintId(System.String)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.String ElmSharp.Window::GetAuxiliaryHintValue(System.Int32)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void ElmSharp.Window::WinKeyGrab(System.String,ElmSharp.KeyGrabMode)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void ElmSharp.Window::WinKeyUngrab(System.String)
|
dongsug-song
force-pushed
the
master-1211
branch
from
2ab78a6 to
5a73927
Compare
Public API ChangedPlease follow the ACR process for the changed API below. Internal API ChangedAdded: 0, Removed: 0, Changed: 29Changed/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
static System.Double ElmSharp.Elementary::GetScale()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
static System.Double ElmSharp.Elementary::GetSystemScrollFriction()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
static System.String ElmSharp.Elementary::GetProfile()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
static System.Void ElmSharp.Elementary::ReloadConfig()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
static System.Void ElmSharp.Elementary::SetScale(System.Double)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
static System.Void ElmSharp.Elementary::SetSystemScrollFriction(System.Double)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
static System.Void ElmSharp.Elementary::ThemeOverlay()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Double ElmSharp.ElmScrollConfig::BringInScrollFriction()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void ElmSharp.EvasImage::SetNativeSurface(System.IntPtr)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void ElmSharp.EvasObjectEvent::.ctor(ElmSharp.EvasObject,System.IntPtr,ElmSharp.EvasObjectCallbackType)
/// <since_tizen>none</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void ElmSharp.EvasObjectEvent`1::.ctor(ElmSharp.EvasObject,System.IntPtr,ElmSharp.EvasObjectCallbackType,ElmSharp.EvasObjectEvent`1/SmartEventInfoParser<TEventArgs>)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Boolean ElmSharp.GenGridItem::IsUseEngineCursor()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.String ElmSharp.GenGridItem::Cursor()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.String ElmSharp.GenGridItem::CursorStyle()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Boolean ElmSharp.GenListItem::IsUseEngineCursor()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.String ElmSharp.GenListItem::Cursor()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.String ElmSharp.GenListItem::CursorStyle()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
ElmSharp.KeyGrabMode
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void ElmSharp.SmartEvent::.ctor(ElmSharp.EvasObject,System.IntPtr,System.String)
/// <since_tizen>none</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void ElmSharp.SmartEvent`1::.ctor(ElmSharp.EvasObject,System.IntPtr,System.String,ElmSharp.SmartEvent`1/SmartEventInfoParser<TEventArgs>)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Boolean ElmSharp.Toolbar::IsHorizontal()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Boolean ElmSharp.Window::Iconified()
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Boolean ElmSharp.Window::DeleteAuxiliaryHint(System.Int32)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Boolean ElmSharp.Window::SetAuxiliaryHintValue(System.Int32,System.String)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Int32 ElmSharp.Window::AddAuxiliaryHint(System.String,System.String)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Int32 ElmSharp.Window::GetAuxiliaryHintId(System.String)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.String ElmSharp.Window::GetAuxiliaryHintValue(System.Int32)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void ElmSharp.Window::WinKeyGrab(System.String,ElmSharp.KeyGrabMode)
/// <since_tizen>preview</since_tizen
+ [Obsolete]
[EditorBrowsable(EditorBrowsableState.Never)]
System.Void ElmSharp.Window::WinKeyUngrab(System.String)
|
dongsug-song
force-pushed
the
master-1211
branch
from
5a73927 to
7df2355
Compare
dongsug-song
changed the title
dongsug-song
changed the title
Public API ChangedPlease follow the ACR process for the changed API below. Internal API ChangedAdded: 0, Removed: 0, Changed: 225 |
wiertel
requested changes
Jan 11, 2024
| @@ -290,6 +307,7 @@ public void SetNativeSurface(IntPtr surface) | |||
| /// <param name="top">The border's top width.</param> | |||
| /// <param name="bottom">The border's bottom width.</param> | |||
| /// <since_tizen> preview </since_tizen> | |||
| [Obsolete("This has been deprecated in API12")] | |||
| public void SetBorder(int left, int right, int top, int bottom) | |||
| { | |||
| Interop.Evas.evas_object_image_border_set(RealHandle, left, right, top, bottom); | |||
There was a problem hiding this comment.
was Save() in line 326 missed or intentionally kept?
There was a problem hiding this comment.
Thank you for review.
it has been fixed.
| @@ -833,6 +876,7 @@ public bool AllEventsFrozen | |||
| /// Sets or gets the layer of its canvas that the given object will be part of. | |||
| /// </summary> | |||
| /// <since_tizen> preview </since_tizen> | |||
| [Obsolete("This has been deprecated in API12")] | |||
| public virtual int Layer | |||
| { | |||
| get | |||
There was a problem hiding this comment.
RenderOperation and related enum (line 118) stay?
There was a problem hiding this comment.
Thank you for review.
it has been fixed.
| public event EventHandler TimeTick; | ||
|
|
||
| /// <summary> | ||
| /// Event arguments that passed via time tick event signal. | ||
| /// </summary> | ||
| [Obsolete("This has been deprecated in API12")] | ||
| public class TimeTickEventArgs : EventArgs | ||
| { | ||
| private WatchTime _watchTime; |
There was a problem hiding this comment.
consider marking those 2 public properties as Obsolete as well, the class is already deprecated, but for consistency members might be as well
There was a problem hiding this comment.
Thank you for review.
it has been fixed.
| @@ -24,7 +24,7 @@ namespace Tizen.NUI.Wearable | |||
| /// <summary> | |||
| /// [Draft] This class provides a View that can recycle items to improve performance. | |||
| /// </summary> | |||
| /// This may be public opened in tizen_6.0 after ACR done. Before ACR, need to be hidden as inhouse API. | |||
| [Obsolete("This has been deprecated in API12")] | |||
| [EditorBrowsable(EditorBrowsableState.Never)] | |||
| public class RecyclerView : ScrollableBase | |||
| { | |||
There was a problem hiding this comment.
consider marking this first constructor as well
There was a problem hiding this comment.
Thank you for review.
it has been fixed.
dongsug-song
force-pushed
the
master-1211
branch
from
7df2355 to
596263c
Compare
Public API ChangedPlease follow the ACR process for the changed API below. Internal API ChangedAdded: 0, Removed: 0, Changed: 226 |
wiertel
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
deprecate unused API.
ElmSharp, ElmSharp.Wearable and NUI.Wearable.
these whole modules are being deprecated.
API Changes
https://jira.sec.samsung.net/browse/TCSACR-564