Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metadata] Deprecate MetadataEditor module #5837

Merged
merged 3 commits into from
Jan 4, 2024
Merged

[Metadata] Deprecate MetadataEditor module #5837

merged 3 commits into from
Jan 4, 2024

Conversation

hsgwon
Copy link
Contributor

@hsgwon hsgwon commented Dec 20, 2023 •
edited
Loading

Description of Change

Deprecate MetadataEditor module

API Changes

  • TCSACR-569

@hsgwon hsgwon added ACR Required API12 Platform : Tizen 9.0 / TFM: net6.0-tizen9.0 labels Dec 20, 2023
@hsgwon hsgwon requested a review from eunhaechoi December 20, 2023 04:34
@TizenAPI-Bot
Copy link
Collaborator

Public API Changed

Please follow the ACR process for the changed API below.

Added: 0, Removed: 0, Changed: 20

Changed

/// <privilege>access</privilege
/// <privilege>access</privilege
/// <privilege>add</privilege
/// <privilege>add</privilege
/// <privilege>an</privilege
/// <privilege>an</privilege
/// <privilege>external</privilege
/// <privilege>http://tizen.org/privilege/externalstorage.</privilege
/// <privilege>http://tizen.org/privilege/mediastorage.</privilege
/// <privilege>if</privilege
/// <privilege>If</privilege
/// <privilege>internal</privilege
/// <privilege>only</privilege
/// <privilege>only</privilege
/// <privilege>Or</privilege
/// <privilege>privilege</privilege
/// <privilege>privilege</privilege
/// <privilege>should</privilege
/// <privilege>should</privilege
/// <privilege>storage,</privilege
/// <privilege>storage,</privilege
/// <privilege>to</privilege
/// <privilege>to</privilege
/// <privilege>want</privilege
/// <privilege>want</privilege
/// <privilege>you</privilege
/// <privilege>you</privilege
/// <privilege>you</privilege
/// <privilege>you</privilege
/// <since_tizen>3</since_tizen
+ [Obsolete]
Tizen.Multimedia.MetadataEditor

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.Int32 Tizen.Multimedia.MetadataEditor::PictureCount()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Album()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Artist()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Author()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Comment()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Conductor()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Copyright()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Date()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Description()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Genre()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Title()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::TrackNumber()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::UnsyncLyrics()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.Void Tizen.Multimedia.MetadataEditor::.ctor(System.String)

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.Void Tizen.Multimedia.MetadataEditor::AddPicture(System.String)

- /// <since_tizen>3</since_tizen
+ /// <since_tizen>none</since_tizen
[Obsolete]
System.Void Tizen.Multimedia.MetadataEditor::Commit()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.Void Tizen.Multimedia.MetadataEditor::Dispose()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.Void Tizen.Multimedia.MetadataEditor::RemovePicture(System.Int32)

/// <since_tizen>3</since_tizen
+ [Obsolete]
Tizen.Multimedia.Artwork Tizen.Multimedia.MetadataEditor::GetPicture(System.Int32)

wiertel
wiertel requested changes Dec 28, 2023
View reviewed changes
src/Tizen.Multimedia.Metadata/MetadataEditor/MetadataEditor.cs Outdated
@@ -439,6 +454,7 @@ public string UnsyncLyrics
/// Internal error.<br/>
/// </exception>
/// <exception cref="ObjectDisposedException">The <see cref="MetadataEditor"/> has already been disposed of.</exception>
[Obsolete("Deprecated in API12; Will be removed in API14")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move that line down, so it not be in the middle of /// comment block

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I'll fix it.

@TizenAPI-Bot
Copy link
Collaborator

Public API Changed

Please follow the ACR process for the changed API below.

Added: 0, Removed: 0, Changed: 20

Changed

/// <privilege>access</privilege
/// <privilege>access</privilege
/// <privilege>add</privilege
/// <privilege>add</privilege
/// <privilege>an</privilege
/// <privilege>an</privilege
/// <privilege>external</privilege
/// <privilege>http://tizen.org/privilege/externalstorage.</privilege
/// <privilege>http://tizen.org/privilege/mediastorage.</privilege
/// <privilege>if</privilege
/// <privilege>If</privilege
/// <privilege>internal</privilege
/// <privilege>only</privilege
/// <privilege>only</privilege
/// <privilege>Or</privilege
/// <privilege>privilege</privilege
/// <privilege>privilege</privilege
/// <privilege>should</privilege
/// <privilege>should</privilege
/// <privilege>storage,</privilege
/// <privilege>storage,</privilege
/// <privilege>to</privilege
/// <privilege>to</privilege
/// <privilege>want</privilege
/// <privilege>want</privilege
/// <privilege>you</privilege
/// <privilege>you</privilege
/// <privilege>you</privilege
/// <privilege>you</privilege
/// <since_tizen>3</since_tizen
+ [Obsolete]
Tizen.Multimedia.MetadataEditor

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.Int32 Tizen.Multimedia.MetadataEditor::PictureCount()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Album()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Artist()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Author()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Comment()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Conductor()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Copyright()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Date()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Description()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Genre()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Title()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::TrackNumber()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::UnsyncLyrics()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.Void Tizen.Multimedia.MetadataEditor::.ctor(System.String)

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.Void Tizen.Multimedia.MetadataEditor::AddPicture(System.String)

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.Void Tizen.Multimedia.MetadataEditor::Commit()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.Void Tizen.Multimedia.MetadataEditor::Dispose()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.Void Tizen.Multimedia.MetadataEditor::RemovePicture(System.Int32)

/// <since_tizen>3</since_tizen
+ [Obsolete]
Tizen.Multimedia.Artwork Tizen.Multimedia.MetadataEditor::GetPicture(System.Int32)

Internal API Changed

Added: 12, Removed: 0, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Binding.BindableProperty Tizen.NUI.BaseComponents.TextLabel::AnchorClickedColorProperty

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Binding.BindableProperty Tizen.NUI.BaseComponents.TextLabel::AnchorColorProperty

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Color Tizen.NUI.BaseComponents.TextLabel::AnchorClickedColor()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Color Tizen.NUI.BaseComponents.TextLabel::AnchorColor()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Binding.BindableProperty Tizen.NUI.BaseComponents.TextLabelStyle::AnchorClickedColorProperty

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Binding.BindableProperty Tizen.NUI.BaseComponents.TextLabelStyle::AnchorColorProperty

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Color Tizen.NUI.BaseComponents.TextLabelStyle::AnchorClickedColor()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Color Tizen.NUI.BaseComponents.TextLabelStyle::AnchorColor()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Int32 Tizen.NUI.Scene3D.Material::DepthIndex()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.Scene3D.MaterialDepthIndexRange

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Scene3D.MaterialDepthIndexRange Tizen.NUI.Scene3D.MaterialDepthIndexRange::Scene

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Scene3D.MaterialDepthIndexRange Tizen.NUI.Scene3D.MaterialDepthIndexRange::UI

@TizenAPI-Bot
Copy link
Collaborator

Public API Changed

Please follow the ACR process for the changed API below.

Added: 0, Removed: 0, Changed: 20

Changed

/// <privilege>access</privilege
/// <privilege>access</privilege
/// <privilege>add</privilege
/// <privilege>add</privilege
/// <privilege>an</privilege
/// <privilege>an</privilege
/// <privilege>external</privilege
/// <privilege>http://tizen.org/privilege/externalstorage.</privilege
/// <privilege>http://tizen.org/privilege/mediastorage.</privilege
/// <privilege>if</privilege
/// <privilege>If</privilege
/// <privilege>internal</privilege
/// <privilege>only</privilege
/// <privilege>only</privilege
/// <privilege>Or</privilege
/// <privilege>privilege</privilege
/// <privilege>privilege</privilege
/// <privilege>should</privilege
/// <privilege>should</privilege
/// <privilege>storage,</privilege
/// <privilege>storage,</privilege
/// <privilege>to</privilege
/// <privilege>to</privilege
/// <privilege>want</privilege
/// <privilege>want</privilege
/// <privilege>you</privilege
/// <privilege>you</privilege
/// <privilege>you</privilege
/// <privilege>you</privilege
/// <since_tizen>3</since_tizen
+ [Obsolete]
Tizen.Multimedia.MetadataEditor

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.Int32 Tizen.Multimedia.MetadataEditor::PictureCount()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Album()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Artist()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Author()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Comment()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Conductor()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Copyright()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Date()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Description()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Genre()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::Title()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::TrackNumber()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.String Tizen.Multimedia.MetadataEditor::UnsyncLyrics()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.Void Tizen.Multimedia.MetadataEditor::.ctor(System.String)

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.Void Tizen.Multimedia.MetadataEditor::AddPicture(System.String)

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.Void Tizen.Multimedia.MetadataEditor::Commit()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.Void Tizen.Multimedia.MetadataEditor::Dispose()

/// <since_tizen>3</since_tizen
+ [Obsolete]
System.Void Tizen.Multimedia.MetadataEditor::RemovePicture(System.Int32)

/// <since_tizen>3</since_tizen
+ [Obsolete]
Tizen.Multimedia.Artwork Tizen.Multimedia.MetadataEditor::GetPicture(System.Int32)

@hsgwon hsgwon merged commit db7077a into Samsung:master Jan 4, 2024
3 checks passed
@hsgwon hsgwon deleted the api12.Metadata.deprecate branch January 4, 2024 01:42
dongsug-song pushed a commit that referenced this pull request Jan 9, 2024
@hsgwon @dongsug-song
[Metadata] Deprecate MetadataEditor module (#5837)
a1e9e40 
* [Metadata] Deprecate MetadataEditor module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiertel wiertel wiertel approved these changes

@eunhaechoi eunhaechoi Awaiting requested review from eunhaechoi

Assignees
No one assigned
Labels
ACR Required API12 Platform : Tizen 9.0 / TFM: net6.0-tizen9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsgwon @TizenAPI-Bot @wiertel