[NUI] Support NativeImageQueue creation with queue count #5851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinohie
requested review from
hyunjushin,
dongsug-song,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst and
rabbitfor
as code owners
Internal API ChangedAdded: 2, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt32 Tizen.NUI.NativeImageQueue::GetQueueCount()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.NativeImageQueue::.ctor(System.UInt32,System.UInt32,System.UInt32,Tizen.NUI.NativeImageQueue/ColorFormat)
|
hinohie
force-pushed
the
native_queue_Size
branch
from
7fb500e to
aff0422
Compare
Internal API ChangedAdded: 2, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt32 Tizen.NUI.NativeImageQueue::GetQueueCount()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.NativeImageQueue::.ctor(System.UInt32,System.UInt32,System.UInt32,Tizen.NUI.NativeImageQueue/ColorFormat)
|
Let we allow to create NativeImageQueue with queue count. Previously, we only allow to create the NativeImageQueue based on the environment value "DALI_TBM_SURFACE_QUEUE_SIZE". (This value is 3 as default) It will be useful if some user want to reduce the queue count for some cases, not for whole queue. relative DALi patches : https://review.tizen.org/gerrit/c/platform/core/uifw/dali-adaptor/+/303523 https://review.tizen.org/gerrit/c/platform/core/uifw/dali-csharp-binder/+/303524 Signed-off-by: Eunki Hong <[email protected]>
hinohie
force-pushed
the
native_queue_Size
branch
from
aff0422 to
caeab36
Compare
Internal API ChangedAdded: 2, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.UInt32 Tizen.NUI.NativeImageQueue::GetQueueCount()
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.NativeImageQueue::.ctor(System.UInt32,System.UInt32,System.UInt32,Tizen.NUI.NativeImageQueue/ColorFormat)
|
JoogabYun
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let we allow to create NativeImageQueue with queue count. Previously, we only allow to create the NativeImageQueue based on the environment value "DALI_TBM_SURFACE_QUEUE_SIZE". (This value is 3 as default)
It will be useful if some user want to reduce the queue count for some cases, not for whole queue.
relative DALi patches :
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-adaptor/+/303523 https://review.tizen.org/gerrit/c/platform/core/uifw/dali-csharp-binder/+/303524