[NUI.Scene3D] Add AddLight API #5854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let we make new API for Light class for SceneView. Note : To avoid the changness of native side code minimalize, let we use internal API of NUI. Signed-off-by: Eunki, Hong <[email protected]>
Build Error: |
Internal API ChangedAdded: 2, Removed: 0, Changed: 0Added+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.Scene3D.SceneView::AddLight(Tizen.NUI.Scene3D.Light)
+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.Scene3D.SceneView::RemoveLight(Tizen.NUI.Scene3D.Light)
|
hinohie
pushed a commit
to hinohie/TizenFX
that referenced
this pull request
Jan 5, 2024
Revert Samsung#5854 PR. We'd better found more good way to fix this issue. This reverts commit 0cb7991.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let we make new API for Light class for SceneView.
Note : To avoid the changness of native side code minimalize, let we use internal API of NUI.