[NUI] Fix text padding issue #5857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch solves the problem that text with padding does not work in nui layout. For text components, the control's padding is used to calculatie size in native, so it should not be set to zero value. This avoids setting padding to zero when it comes to text layout. Signed-off-by: Bowon Ryu <[email protected]>
jaehyun0cho
requested review from
wonrst,
hyunjushin,
dongsug-song,
Seoyeon2Kim,
taehyub,
everLEEst,
rabbitfor and
hinohie
as code owners
hinohie
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch solves the problem that text with padding does not work in nui layout.
For text components, the control's padding is used to calculatie size in native, so it should not be set to zero value.
This avoids setting padding to zero when it comes to text layout.
Description of Change
API Changes