Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(artifact_collector): artifacts collection for conditional steps #716

Merged
merged 11 commits into from
Nov 21, 2022
Merged

feat(artifact_collector): artifacts collection for conditional steps #716

merged 11 commits into from
Nov 21, 2022

Conversation

miltolstoy
Copy link
Collaborator

@miltolstoy miltolstoy commented Apr 27, 2022 •
edited
Loading

This PR contains:

  1. Handling conditional step branches artifacts
  2. Conditional steps tests update to check files created instead of the log line

Similar changes will be applied to the configuration.report_artifacts in the next PR after this change will be reviewed and updated accordingly.

Relates #709

@i-keliukh
Copy link
Contributor

The requirements for the artifact processing for conditional steps are missing in this PR.
I think it would be good to have them listed in the form of product documentation included in this PR.

@miltolstoy miltolstoy mentioned this pull request Sep 23, 2022
Closed
@miltolstoy miltolstoy force-pushed the conditional_steps branch 2 times, most recently from a413b31 to 387c6ac Compare October 3, 2022 05:55
@k-dovgan
Copy link
Contributor

k-dovgan commented Oct 7, 2022

Please ignore this comment.

Base automatically changed from conditional_steps_old to conditional_steps October 20, 2022 04:36
@miltolstoy miltolstoy force-pushed the conditional_steps_artifacts branch from d5ceaff to 36c7052 Compare October 24, 2022 04:57
@miltolstoy
Copy link
Collaborator Author

The requirements for the artifact processing for conditional steps are missing in this PR. I think it would be good to have them listed in the form of product documentation included in this PR.

It appears that artifact processing for conditional steps is similar to regular steps. It makes more sense to describe conditional steps logic in general and make small notes about artifacts processing in several places.
Agreed to be done in a separate PR because it's not related to the artifacts processing only.

@miltolstoy miltolstoy requested a review from i-keliukh November 21, 2022 04:48
@miltolstoy miltolstoy merged commit 9525f51 into conditional_steps Nov 21, 2022
@miltolstoy miltolstoy deleted the conditional_steps_artifacts branch November 21, 2022 07:41
@miltolstoy miltolstoy mentioned this pull request Apr 10, 2023
Open
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-keliukh i-keliukh i-keliukh approved these changes

@k-dovgan k-dovgan Awaiting requested review from k-dovgan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miltolstoy @i-keliukh @k-dovgan