fix: error handling for download

Sanket322 · Dec 9, 2024 · 4523b41 · 4523b41
1 parent d4f5226
commit 4523b41
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/...compliance/gst_india/doctype/purchase_reconciliation_tool/purchase_reconciliation_tool.js b/...compliance/gst_india/doctype/purchase_reconciliation_tool/purchase_reconciliation_tool.js
@@ -70,6 +70,15 @@ frappe.ui.form.on("Purchase Reconciliation Tool", {
         await frappe.require("purchase_reconciliation_tool.bundle.js");
         frm.trigger("company");
         frm.purchase_reconciliation_tool = new PurchaseReconciliationTool(frm);
+
+        frappe.realtime.on("download_failed", message => {
+            frm.dashboard.hide();
+            frappe.msgprint({
+                title: __("Download Failed"),
+                message: message.error,
+                indicator: "red"
+            });
+        })
     },
 
     onload(frm) {

diff --git a/...compliance/gst_india/doctype/purchase_reconciliation_tool/purchase_reconciliation_tool.py b/...compliance/gst_india/doctype/purchase_reconciliation_tool/purchase_reconciliation_tool.py
@@ -460,11 +460,20 @@ def download_gstr(
     if not periods:
         return
 
-    if return_type == ReturnType.GSTR2A:
-        return download_gstr_2a(company_gstin, periods, gst_categories)
+    try:
+        if return_type == ReturnType.GSTR2A:
+            return download_gstr_2a(company_gstin, periods, gst_categories)
 
-    if return_type == ReturnType.GSTR2B:
-        return download_gstr_2b(company_gstin, periods)
+        if return_type == ReturnType.GSTR2B:
+            return download_gstr_2b(company_gstin, periods)
+
+    except Exception as e:
+        frappe.publish_realtime(
+            "download_failed",
+            {"error": str(e)},
+            user=frappe.session.user,
+            doctype="Purchase Reconciliation Tool",
+        )
 
 
 def get_periods_to_download(company_gstin, return_type, periods):