This repository was archived by the owner on Aug 27, 2024. It is now read-only.
Upgrade the Enum class #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/ValuedEnum.php
Outdated
| } | ||
|
|
||
| /** | ||
| * Returns the name that associated with the current enum value. |
There was a problem hiding this comment.
Sholdn't it be 'Returns the value ...'?
src/ValuedEnum.php
Outdated
| namespace Saritasa; | ||
|
|
||
| /** | ||
| * The base class for enums that associated with one string value. |
There was a problem hiding this comment.
Shouldn't it be '... with one numeric value'?
README.md
Outdated
| } | ||
| } | ||
| ... | ||
| $xor = LogicOperations::XOR(); // will throw InvalidEnumValueException on unknown value |
There was a problem hiding this comment.
Why this throws an exception if XOR constant defined in LogicOperations enum?
There was a problem hiding this comment.
This is old comment. I'll add new code line with non-existing constant.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new version of Enum is more powerful than the previous one and more appropriate for OOP. The changes are incompatible with the previous code, so the version is 2.0.0