Skip to content
This repository was archived by the owner on Aug 27, 2024. It is now read-only.

Add resolving dependencies on factory side #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

veeeeeRySeXy
Copy link
Contributor

Changes:

  • Resolving service dependency now happened on factory side in case if service inherit EntityService class
    and don't has own constructor.

Fixes #2

@veeeeeRySeXy veeeeeRySeXy requested a review from populov March 19, 2019 06:57
@codecov-io
Copy link

codecov-io commented Mar 19, 2019

Codecov Report

Merging #3 into master will increase coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master       #3     +/-   ##
===========================================
+ Coverage     85.26%   85.56%   +0.3%     
- Complexity       38       39      +1     
===========================================
  Files             6        6             
  Lines            95       97      +2     
===========================================
+ Hits             81       83      +2     
  Misses           14       14
Impacted Files Coverage Δ Complexity Δ
src/Services/EntityServiceFactory.php 100% <100%> (ø) 11 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cac8e0...a13424b. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants