Add a configurable wait period for shared resource #17464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobCallahan
added
Easy Fix :)
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (1)
- conf/robottelo.yaml.template: Language not supported
Comments suppressed due to low confidence (1)
robottelo/config/validators.py:333
- The pull request title and description contain a typo: 'wat' should be 'wait'.
Validator('robottelo.shared_resource_wait', default=60, is_type_of=int),
ogajduse
requested changes
Feb 6, 2025
There was a problem hiding this comment.
We are now down to 6 seconds of test time if executed as below.
ROBOTTELO_ROBOTTELO__SHARED_RESOURCE_WAIT=2 ROBOTTELO_SERVER__HOSTNAME="" VAULT_SECRET_ID_FOR_DYNACONF=somesecret pytest tests/robottelo/test_shared_resource.py
I left one comment - I would like to enable users to set the wait time to less than 1 second.
It would be beneficial to drop this lower for tests.
JacobCallahan
force-pushed
the
for_ondrej
branch
from
00f82e4 to
2174abb
Compare
synkd
approved these changes
Feb 13, 2025
ogajduse
approved these changes
Feb 13, 2025
|
Thanks for the patch, @JacobCallahan! |
This was referenced Feb 13, 2025
ogajduse
pushed a commit
to ogajduse/robottelo
that referenced
this pull request
Feb 14, 2025
Add a configurable wat period for shared resource It would be beneficial to drop this lower for tests. (cherry picked from commit 1995f76)
ogajduse
pushed a commit
to ogajduse/robottelo
that referenced
this pull request
Feb 14, 2025
Add a configurable wat period for shared resource It would be beneficial to drop this lower for tests. (cherry picked from commit 1995f76)
ogajduse
pushed a commit
to ogajduse/robottelo
that referenced
this pull request
Feb 14, 2025
Add a configurable wat period for shared resource It would be beneficial to drop this lower for tests. (cherry picked from commit 1995f76)
This was referenced Feb 14, 2025
Gauravtalreja1
pushed a commit
that referenced
this pull request
Feb 14, 2025
Add a configurable wait period for shared resource (#17464) Add a configurable wat period for shared resource It would be beneficial to drop this lower for tests. (cherry picked from commit 1995f76) Co-authored-by: Jake Callahan <[email protected]>
Gauravtalreja1
pushed a commit
that referenced
this pull request
Feb 14, 2025
…17600) Add a configurable wait period for shared resource (#17464) Add a configurable wat period for shared resource It would be beneficial to drop this lower for tests. (cherry picked from commit 1995f76) Co-authored-by: Jake Callahan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be beneficial to drop this lower for tests.