feat!: generic key bindings#555
Open
robertwidfen wants to merge 1 commit into
Open
Conversation
See issue Satty-org#450. Changes syntax for [keybinds] section in config file to "key" = "tool-or-command" Also adds: - bindings for all toolbar buttons - commands for size selection - automatic hint generation for all buttons Removes: - layout independent key bindings - instead bind what you want - single letter binding restriction Old style is still supported but will generate deprecation warnings. The old code always sent key events into the IME handling before they were processed as key event. Thus there were two places for bindings, bindings with a modifier and single letter bindings. But IME is for text input, thus it is now only activated for the text tool.
Member
|
Good work, code looks good to me with just a few tiny inline remarks. Not that many for such a big change. What I tested worked. Difficult to try out everything 😄 IME still works as far as I can tell. But I'm not the greatest expert for it. I'm not sure if I should say "it still works", perhaps somebody else sees this and can confirm this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #450.
Changes syntax for [keybinds] section in config file to
Also adds:
Removes:
Old style is still supported but will generate deprecation warnings.
The old code always sent key events into the IME handling before they were processed as key event. Thus there were two places for bindings, bindings with a modifier and single letter bindings. But IME is for text input, thus it is now only activated for the text tool.