feat: Compress other wallets into a modal on DEVNET - #589
Merged
metalboyrick merged 9 commits intoJul 5, 2025
Conversation
Contributor
Author
|
|
metalboyrick
changed the title
metalboyrick
requested changes
Jul 3, 2025
metalboyrick
left a comment
metalboyrick
left a comment
Collaborator
There was a problem hiding this comment.
GM Ser, thanks for the PR
Please keep styling consistent with other buttons (you can just use the style from there) (or you can just use ghost buttons for this)
Contributor
Author
|
Can you, please, be more specific? |
metalboyrick
requested changes
Jul 4, 2025
metalboyrick
left a comment
metalboyrick
left a comment
Collaborator
There was a problem hiding this comment.
can we make this a ghost button as well?
Also please make sure the CI is green
Contributor
Author
|
@metalboyrick done ser! |
metalboyrick
self-requested a review
July 5, 2025 15:03
metalboyrick
approved these changes
Jul 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In DEVNET only: Hide Argent, Braavos, and other 3rd-party wallet buttons from the main wallet connect modal.
Types of change
Summary of Steps