Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/toast #206

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Fix/toast #206

merged 4 commits into from
Feb 14, 2025

Conversation

iossocket
Copy link
Collaborator

Toast display

Types of change

  1. show error detail in toast
  2. add url check for contract
  3. disable submit button when submitted
  4. use toast loading to display progress
  • Feature
  • Bug
  • Enhancement

@metalboyrick
Copy link
Collaborator

@iossocket did i miss any config?
image

Copy link
Collaborator

@metalboyrick metalboyrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one

image

just a question we only intend to show one mistake at a time? cc @jrcarlos2000

@0xquantum3labs
Copy link
Collaborator

nice one

image just a question we only intend to show one mistake at a time? cc @jrcarlos2000

yes , listing many would look to heavy on the toast ?

@0xquantum3labs 0xquantum3labs self-assigned this Feb 14, 2025
@0xquantum3labs 0xquantum3labs merged commit 635b0e5 into main Feb 14, 2025
2 checks passed
@0xquantum3labs 0xquantum3labs deleted the fix/toast branch February 14, 2025 10:22
@metalboyrick
Copy link
Collaborator

@0xquantum3labs i mean we can consider using sth thats not a toast haha, but i dont think the servers gonna be loaded anyways, so its fine to have just toasts one-by-one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants