-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build for gnu instead of musl #882
base: master
Are you sure you want to change the base?
Conversation
Redoing Schniz#389 which was cancelled by Schniz#554 and reintroduced the error. Fixes Schniz#520
|
- uses: actions/checkout@v3 | ||
- name: Build release binary | ||
run: cargo build --release --target x86_64-unknown-linux-musl | ||
- name: Strip binary from debug symbols | ||
run: strip target/x86_64-unknown-linux-musl/release/fnm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for strip anymore since Cargo 1.59
Another small win with this PR is that the binary goes from 7.2MB to 6.5MB... |
This means vc alpine-based docker images will fail to use fnm. Right? |
Ahh and also thank you very much for digging deep and figuring out the issue. Reaaaaally appreciate it 🙌 |
Thats right, I am not sure who does that (fnm in a docker image kind of defy the purpose IMO) but I guess if you ask, you might have encountered the use case.
You mean using a matrix and |
Redoing #389 which was cancelled by #554 and reintroduced the error.
Fixes #520