Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added translate, scale, their test files, and docs #99

Merged
merged 5 commits into from
Mar 11, 2021
Merged

added translate, scale, their test files, and docs #99

merged 5 commits into from
Mar 11, 2021

Conversation

VB256
Copy link
Contributor

@VB256 VB256 commented Mar 1, 2021

Closes #88

AlphaRLee
AlphaRLee requested changes Mar 1, 2021
View reviewed changes
Copy link
Member

@AlphaRLee AlphaRLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but lots of nitpicks about your docs formatting and a couple edge cases missing from your scale unit tests

@AlphaRLee
Copy link
Member

Also could you quickly try a unit test for translate with floats? Right now you have ints. Should work fine, but I don't want to take chances (libraries like Pygame crash when you feed floats)

@VB256 VB256 requested a review from AlphaRLee March 7, 2021 18:56
@VB256 VB256 merged commit 8d706a4 into dev Mar 11, 2021
@VB256 VB256 deleted the vikram/scaletranslate branch March 11, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlphaRLee AlphaRLee AlphaRLee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VB256 @AlphaRLee