-
Notifications
You must be signed in to change notification settings - Fork 20
1178 code creation based on standardised formats for ODEs #1235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1178 code creation based on standardised formats for ODEs #1235
Conversation
…sed-on-standardised-formats-for-ODEs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1235 +/- ##
=======================================
Coverage 97.28% 97.28%
=======================================
Files 168 168
Lines 14858 14858
=======================================
Hits 14454 14454
Misses 404 404 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HenrZu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition! i had a first look at it and have some comments. I still need to look into the sbml.h file more in detail and also into the doc.
Co-authored-by: Henrik Zunker <[email protected]>
reneSchm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge main again so that the CI can pass, then I think this is good to go.
Note: This new functionality is not covered by unit tests, instead it has its own CI job.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #1178