Skip to content

Conversation

@kilianvolmer
Copy link
Contributor

@kilianvolmer kilianvolmer commented Mar 24, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Add memilio2sbml executable
  • Add documentation for memilio2sbml executable

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Closes #1178

@kilianvolmer kilianvolmer added class::feature A feature to be implemented for some part of the software model::ode This issue concerns any kind of ODE-based model. labels Mar 24, 2025
@kilianvolmer kilianvolmer requested review from HenrZu and reneSchm March 24, 2025 14:29
@codecov
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.28%. Comparing base (8b250bd) to head (3bc4283).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1235   +/-   ##
=======================================
  Coverage   97.28%   97.28%           
=======================================
  Files         168      168           
  Lines       14858    14858           
=======================================
  Hits        14454    14454           
  Misses        404      404           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@HenrZu HenrZu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! i had a first look at it and have some comments. I still need to look into the sbml.h file more in detail and also into the doc.

Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge main again so that the CI can pass, then I think this is good to go.

Note: This new functionality is not covered by unit tests, instead it has its own CI job.

@HenrZu HenrZu merged commit e13840f into main Jun 26, 2025
69 checks passed
@HenrZu HenrZu deleted the 1178-code-creation-based-on-standardised-formats-for-ODEs branch June 26, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

class::feature A feature to be implemented for some part of the software model::ode This issue concerns any kind of ODE-based model.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code creation based on standardised formats for ODEs

4 participants