-
Notifications
You must be signed in to change notification settings - Fork 16
211 Python dependencies #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #221 +/- ##
=======================================
Coverage 91.23% 91.23%
=======================================
Files 77 77
Lines 4721 4721
=======================================
Hits 4307 4307
Misses 414 414 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI throws an FileNotFoundError Error in the RKI File. I don't think the axis=1 does this. Do you know why it throws that error?
Else, looks good!
May be the same error that is thrown in CI on the main branch? |
Looks like it. I will look into it ( maybe @annette-lutz we can discuss it tomorow morning.) |
The FileNotFoundError is thrown because the link to the data from RKI is outdated. That is the case for the main branch and this branch. This is corrected in pull request #216 where the source for the rki data is changed to github and the link failing here is changed to the current link and used as a fallback variant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to properly connect PRs to issues and add a line to the description of the PR that closes the issue, "Closes #" or similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
is present or referenced. Please provide your references.
Checks by code reviewer(s):
closes #211