QA: run_qa v1.6 form + ExplicitImports#387
Merged
ChrisRackauckas merged 1 commit intoJun 27, 2026
Merged
Conversation
Convert the hand-rolled test/qa Aqua + JET files to a single qa.jl on the SciMLTesting 1.6 `run_qa` form, with ExplicitImports enabled. ExplicitImports findings, resolved FIX > IGNORE: - no_stale_explicit_imports: drop stale `SMatrix` import. - no_implicit_imports: make the 11 implicit LinearAlgebra names explicit (`using LinearAlgebra: LinearAlgebra, Adjoint, ...`). - all_qualified_accesses_via_owners: `Broadcast.unalias` -> `Base.unalias` (owner is Base). - all_qualified_accesses_are_public / all_explicit_imports_are_public: ignore Base/Base.Broadcast/Base.Iterators internals plus non-public names from Adapt/ChainRulesCore/ArrayInterface/StaticArrayInterface/StaticArraysCore/ Functors/LinearAlgebra (method-extension imports). Aqua `ambiguities`/`unbound_args` stay disabled as genuine aqua_kwargs (real, long-standing vcat/hcat/getindex/Axis findings, not tracked-broken). JET runs hard (test_package clean on 1.10). test/qa/Project.toml: drop Aqua + transitive ExplicitImports, bump SciMLTesting compat to "1.6". Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ignore until reviewed by @ChrisRackauckas.
Brings
test/qaonto the SciMLTesting 1.6run_qaform with ExplicitImports enabled. The two hand-rolled files (aqua_tests.jl,jet_tests.jl) collapse into a singleqa.jl.ExplicitImports findings (6 checks, resolved FIX > IGNORE; 0 hard FAIL/BROKEN)
Fixed (4 checks now pass clean):
no_stale_explicit_imports: dropped staleSMatrix(imported, never used).no_implicit_imports: made the 11 implicitLinearAlgebranames explicit —using LinearAlgebra: LinearAlgebra, Adjoint, Cholesky, Diagonal, I, LU, Transpose, UniformScaling, axpby!, axpy!, ldiv!.all_qualified_accesses_via_owners:Broadcast.unalias→Base.unalias(unaliasis owned byBase).all_explicit_imports_via_owners: already passing.Ignored (other packages'/Base internals, all method-extension imports; go public as base libs declare them):
all_qualified_accesses_are_public: Base / Base.Broadcast / Base.Iterators internals (@propagate_inbounds,Bottom,BroadcastStyle,Generator,OneTo,ProductIterator,ReshapedArray,axistype,broadcast_unalias,combine_axes,dataids,elsize,maybeview,print_array,print_matrix,to_index,unalias,unsafe_convert), plus non-public names from LinearAlgebra (BlasInt,lutype), Adapt (adapt_storage,adapt_structure), ChainRulesCore (backing), ArrayInterface (indices_do_not_alias,instances_do_not_alias,lu_instance,parent_type), StaticArrayInterface (static_size), Functors (functor). Each ignore is annotated with its source package.all_explicit_imports_are_public:StaticArrayfrom StaticArraysCore (not declared public there yet).No
ei_brokenneeded — every EI check is FIX or IGNORE.Aqua / JET
ambiguitiesandunbound_argsstay disabled viaaqua_kwargs(real, long-standing findings in the vcat/hcat/getindex/Axis overloads — genuine design realities, not tracked-broken placeholders; preserves the priorAqua.test_all(..., ambiguities=false, unbound_args=false)behavior).test_package, clean on Julia 1.10), replacing the prior targeted@report_opt/@report_callset (the whole-package check is broader).Deps (
test/qa/Project.toml)Aqua(provided transitively by SciMLTesting; theambiguitieschild-proc requirement doesn't apply since it's disabled) and the transitiveExplicitImports.SciMLTestingcompat to"1.6".Verified locally (Julia 1.10, released SciMLTesting 1.6.0, no dev-from-branch)
GROUP=QAviarun_tests: 16 pass, 0 fail, 0 error, 0 broken.GROUP=Core: all files pass (pre-existing@test_brokenin broadcasting_tests unchanged), confirming the explicitLinearAlgebraimports andBase.unaliasdon't change runtime behavior.🤖 Generated with Claude Code