Fix: declare Pkg as a test dep (grouped-tests Core group regression)#42
Merged
ChrisRackauckas merged 1 commit intoJun 10, 2026
Merged
Conversation
The grouped-tests conversion's runtests.jl does `using Pkg` (for the QA group's Pkg.activate), but Pkg wasn't a declared test dependency, so the Core job (project='.') failed with `Package Pkg not found in current path` before any test ran. Add Pkg to test/Project.toml [deps]. Verified locally on Julia 1.11: GROUP=Core passes (39 tests) and GROUP=QA passes (Aqua 11/11, JET 1/1). Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conversion #40 made
test/runtests.jldousing Pkg(for the QA group'sPkg.activate) but didn't declarePkgas a test dep, so the Core job (project='.') failed withArgumentError: Package Pkg not foundbefore any test ran — main CI is red because of it. Fix: addPkgtotest/Project.toml. Verified locally (Julia 1.11): GROUP=Core 39 tests pass, GROUP=QA passes (Aqua 11/11, JET 1/1). Same pattern affects the other B/C conversions; sweeping them. Ignore until reviewed by @ChrisRackauckas.