test: add missing using Test to runtests.jl (fixes @testset UndefVarError)#43
Closed
ChrisRackauckas-Claude wants to merge 1 commit into
Closed
test: add missing using Test to runtests.jl (fixes @testset UndefVarError)#43ChrisRackauckas-Claude wants to merge 1 commit into
using Test to runtests.jl (fixes @testset UndefVarError)#43ChrisRackauckas-Claude wants to merge 1 commit into
Conversation
…rError) Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
|
Superseded by the SciMLTesting v1.2 migration (folder-based |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test/runtests.jlopens withusing Pkgbut never importsTest. It then calls@testset/@test_throwsat the top level (the "Invalid usage error path" block), so the test process dies with:This is a test-harness scaffolding bug introduced by the grouped-tests conversion (the top-level
@testsetwas added toruntests.jlitself, which unlikecore.jlhas nousing Test). It breaks the Core, downgrade, and All-group CI.Fix
Add the missing
using Testimmediately afterusing PkgsoTestis in scope before the top-level@testset. This is the minimal change — one import line. No test assertions or logic were touched. (core.jlalready has its ownusing Test.)Verification
Ran locally on Julia 1.11:
Result — all groups pass, including the previously-failing top-level testset:
Ignore until reviewed by @ChrisRackauckas.