Use SciMLTesting v1.2 (folder-based run_tests)#44
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Conversation
Convert the test suite to the SciMLTesting v1.2 folder-discovery model: - runtests.jl becomes `using SciMLTesting; run_tests()`. - Core: the monolithic core.jl is split into self-contained top-level files (unit_tests.jl, end_to_end_tests.jl, issue_3.jl, commutation_tests.jl), each run isolated in its own @safetestset by folder discovery. The previously unconditional "Invalid usage error path" testset becomes a self-contained Core file (invalid_usage_tests.jl) — it is a macro-correctness unit test that belongs to Core; CI still exercises it on the Core lane. - QA stays at test/qa/ with its existing qa.jl + Project.toml sub-env. - SciMLTesting + SafeTestsets added to the main test env and the QA sub-env; Pkg dropped from the test env (no test file uses it; the harness owns Pkg ops). test_groups.toml unchanged. - Removed the checked-in test/Manifest.toml: it is gitignored and was stale after the dependency change, so Pkg re-resolves it fresh. Core's assertion set is preserved exactly (42 @test/@test_throws before and after, including the moved invalid-usage check). Per the v1.2 folder semantics the QA group is its own CI lane and is not part of the local `All` default. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
4886fd4 to
a11985f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts ConcreteStructs.jl's test suite to the SciMLTesting v1.2 folder-discovery model.
What changed
runtests.jlbecomesusing SciMLTesting; run_tests()(bare folder-discovery).core.jlinto self-contained top-level files —unit_tests.jl,end_to_end_tests.jl,issue_3.jl,commutation_tests.jl— each run isolated in its own@safetestsetby folder discovery.invalid_usage_tests.jl. It is a@concretemacro-correctness unit test and belongs to Core; CI continues to exercise it on the Core lane.test/qa/with its existingqa.jl+Project.tomlsub-env.SciMLTesting+SafeTestsetsadded to the main test env and the QA sub-env;Pkgdropped from the test env (no test file uses it; the harness owns all Pkg ops).test_groups.tomlunchanged.test/Manifest.toml(it is gitignored and was stale after the dep change; Pkg re-resolves it fresh).Verification
TOML.parsefileon everyProject.toml+test_groups.toml: OK.Meta.parseallonruntests.jland every moved/new test file: OK.@test/@test_throwsbefore and after (including the moved invalid-usage check).run_testsfolder-discovery dispatcher over everyGROUPvalue:Coreruns the 5 top-level files isolated;QAactivates theqa/sub-env and runsqa.jl;Allruns Core (QA is its own CI lane per the v1.2 folder semantics). CI dispatchesCoreandQAas separate matrix lanes fromtest_groups.toml.This supersedes the v1.0.0 harness form previously on this branch and the
canonicalize-safetestsetPR.Ignore until reviewed by @ChrisRackauckas.