BVP cleanup - #4405
Merged
Merged
Conversation
SebastianM-C
force-pushed
the
smc/bvp_cleanup
branch
2 times, most recently
from
May 8, 2026 20:26
8205b68 to
d3b929f
Compare
SebastianM-C
force-pushed
the
smc/bvp_cleanup
branch
from
August 6, 2026 02:51
d3b929f to
a9a1502
Compare
The discrepancy between the interpolation methods is fixed by SciML/BoundaryValueDiffEq.jl#452
for the BVP case the solution is more precise at default tolerances
SebastianM-C
force-pushed
the
smc/bvp_cleanup
branch
from
August 6, 2026 12:54
a9a1502 to
457fbce
Compare
Member
Author
|
@AayushSabharwal can you take a look at this one too? It should clean up the workarounds for some old interpolation bug that was fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in the BVP interpolation and I added some tests
that were using the internals of BVP solvers. That is no longer needed.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
See also SciML/BoundaryValueDiffEq.jl#452
The tests should pass once that merges (and it's released).