Skip to content

fix: handle case in SCCNonlinearProblem when no guesses are provided - #4743

Merged
AayushSabharwal merged 1 commit into
masterfrom
as/fix-sccnlprob-no-guesses
Jul 14, 2026
Merged

fix: handle case in SCCNonlinearProblem when no guesses are provided#4743
AayushSabharwal merged 1 commit into
masterfrom
as/fix-sccnlprob-no-guesses

Conversation

@AayushSabharwal

Copy link
Copy Markdown
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia vlts)

Time benchmarks
master fd3d89f... master / fd3d89f...
ODEProblem 5.86 ± 0.64 ms 6.67 ± 1.6 ms 0.879 ± 0.23
init 0.0905 ± 0.029 ms 0.0979 ± 0.026 ms 0.925 ± 0.39
large_parameter_init/ODEProblem 28.2 ± 5.1 ms 30 ± 6.5 ms 0.94 ± 0.27
large_parameter_init/init 0.121 ± 0.045 ms 0.127 ± 0.043 ms 0.952 ± 0.48
mtkcompile 9.6 ± 0.98 ms 11.7 ± 3.4 ms 0.818 ± 0.25
sparse_analytical_jacobian/ODEProblem 29 ± 3.8 ms 0.0327 ± 0.0063 s 0.886 ± 0.21
sparse_analytical_jacobian/f_iip 0.07 ± 0.01 μs 0.07 ± 0.01 μs 1 ± 0.2
sparse_analytical_jacobian/f_oop 0.383 ± 0.022 ms 0.377 ± 0.024 ms 1.02 ± 0.086
time_to_load 7.32 ± 0.41 s 9.3 ± 0.6 s 0.787 ± 0.067
Memory benchmarks
master fd3d89f... master / fd3d89f...
ODEProblem 0.0395 M allocs: 1.99 MB 0.0395 M allocs: 1.99 MB 1
init 0.417 k allocs: 0.0698 MB 0.417 k allocs: 0.0698 MB 1
large_parameter_init/ODEProblem 0.323 M allocs: 11.3 MB 0.323 M allocs: 11.3 MB 1
large_parameter_init/init 0.605 k allocs: 0.172 MB 0.605 k allocs: 0.172 MB 1
mtkcompile 0.061 M allocs: 3.3 MB 0.061 M allocs: 3.32 MB 0.995
sparse_analytical_jacobian/ODEProblem 0.19 M allocs: 7.81 MB 0.191 M allocs: 7.84 MB 0.996
sparse_analytical_jacobian/f_iip 0 allocs: 0 B 0 allocs: 0 B
sparse_analytical_jacobian/f_oop 0.634 k allocs: 19.6 kB 0.634 k allocs: 19.6 kB 1
time_to_load 0.153 k allocs: 14.6 kB 0.153 k allocs: 14.6 kB 1

@AayushSabharwal
AayushSabharwal force-pushed the as/fix-sccnlprob-no-guesses branch from a7b82ff to fd3d89f Compare July 13, 2026 12:53
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia v1)

Time benchmarks
master fd3d89f... master / fd3d89f...
ODEProblem 12.4 ± 2.9 ms 7.75 ± 0.93 ms 1.6 ± 0.42
init 0.0846 ± 0.012 ms 0.087 ± 0.011 ms 0.973 ± 0.19
large_parameter_init/ODEProblem 0.0481 ± 0.016 s 0.0364 ± 0.0054 s 1.32 ± 0.48
large_parameter_init/init 0.0937 ± 0.045 ms 0.0974 ± 0.041 ms 0.961 ± 0.62
mtkcompile 16.3 ± 4.1 ms 12.4 ± 1.2 ms 1.32 ± 0.35
sparse_analytical_jacobian/ODEProblem 0.0399 ± 0.0054 s 0.0343 ± 0.0034 s 1.16 ± 0.2
sparse_analytical_jacobian/f_iip 1.89 ± 0.84 μs 1.89 ± 0.56 μs 1 ± 0.53
sparse_analytical_jacobian/f_oop 0.123 ± 0.013 ms 0.123 ± 0.014 ms 1 ± 0.16
time_to_load 6.81 ± 0.27 s 6.57 ± 0.3 s 1.04 ± 0.063
Memory benchmarks
master fd3d89f... master / fd3d89f...
ODEProblem 0.0397 M allocs: 1.83 MB 0.0397 M allocs: 1.8 MB 1.02
init 0.416 k allocs: 0.0518 MB 0.416 k allocs: 0.0518 MB 1
large_parameter_init/ODEProblem 0.351 M allocs: 12.8 MB 0.351 M allocs: 12.8 MB 1
large_parameter_init/init 0.799 k allocs: 0.152 MB 0.799 k allocs: 0.152 MB 1
mtkcompile 0.0592 M allocs: 2.62 MB 0.0592 M allocs: 2.62 MB 1
sparse_analytical_jacobian/ODEProblem 0.185 M allocs: 6.88 MB 0.185 M allocs: 6.88 MB 1
sparse_analytical_jacobian/f_iip 0 allocs: 0 B 0 allocs: 0 B
sparse_analytical_jacobian/f_oop 0.848 k allocs: 27 kB 0.848 k allocs: 27 kB 1
time_to_load 0.146 k allocs: 11.4 kB 0.146 k allocs: 11.4 kB 1

@AayushSabharwal
AayushSabharwal merged commit 2626464 into master Jul 14, 2026
106 of 122 checks passed
@AayushSabharwal
AayushSabharwal deleted the as/fix-sccnlprob-no-guesses branch July 14, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant