Adopt SciMLTesting 2.4 strict QA - #4832
Draft
ChrisRackauckas-Claude wants to merge 7 commits into
Draft
Conversation
Member
Author
|
Strict-QA audit note (2026-07-30):
|
Member
Author
|
Follow-up validation:
|
ChrisRackauckas-Claude
force-pushed
the
agent/scimltesting-v24-strict-qa
branch
from
August 1, 2026 20:02
900da33 to
2f62276
Compare
ChrisRackauckas-Claude
force-pushed
the
agent/scimltesting-v24-strict-qa
branch
2 times, most recently
from
August 4, 2026 08:45
f15a89f to
53390b6
Compare
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Rewriting the deprecated system aliases from `@deprecate` to hand-written `Base.depwarn` functions dropped their exports: `@deprecate` exports the deprecated name by default, a plain function definition does not. `NonlinearSystem` and `ODESystem` survived only because they are listed explicitly; `DiscreteSystem` and `ImplicitDiscreteSystem` were not, so both became unreachable and `sciml_problem_inputs.jl` failed with `UndefVarError`. Comparing `names(ModelingToolkitBase)` and `names(ModelingToolkit)` against master shows these two were the only names lost and none were gained; with this change both lists match master exactly. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019ywCW8vbGoc9X3dUbmXyme
Rewriting the independent-variable docs to attach directly to `const t_nounits` and `const D_nounits` dropped the separate `@doc` blocks that documented the unitful `t` and `D`. Those are distinct bindings — the DynamicQuantities sentinels declared in `unit_check.jl` — not aliases of the `_nounits` pair, so documenting the latter did not cover them. Both remain `@public`, which left two public names with no docstring and failed the api-docs check. Document them at their definition site. This takes the undocumented public API from 11 names to 9; the remainder are the Symbolics-owned reexports this branch intentionally stops waiving. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019ywCW8vbGoc9X3dUbmXyme
ChrisRackauckas-Claude
force-pushed
the
agent/scimltesting-v24-strict-qa
branch
from
August 5, 2026 10:56
770c7da to
51d0232
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[sources]paths and QA suppressionsVerification
git diff --checkpassedRequired follow-up
The strict failures need public-API owner changes (especially Symbolics/SymbolicUtils and the ModelingToolkitBase/StateSelection boundaries) plus an explicit, SemVer-major replacement for blanket reexports. They are intentionally not waived here.
Ignore until reviewed by @ChrisRackauckas.