Skip to content

fix: properly forward t kwarg in get_sensitivity and family - #4854

Merged
AayushSabharwal merged 1 commit into
masterfrom
as/get-sens-t
Aug 5, 2026
Merged

fix: properly forward t kwarg in get_sensitivity and family#4854
AayushSabharwal merged 1 commit into
masterfrom
as/get-sens-t

Conversation

@AayushSabharwal

Copy link
Copy Markdown
Member

Close #4838

@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia vlts)

Time benchmarks
master dcfff24... master / dcfff24...
ODEProblem 5.91 ± 0.51 ms 5.94 ± 0.4 ms 0.996 ± 0.11
init 0.0953 ± 0.028 ms 0.095 ± 0.031 ms 1 ± 0.44
large_parameter_init/ODEProblem 21.1 ± 2.5 ms 19.9 ± 1.9 ms 1.06 ± 0.16
large_parameter_init/init 0.0988 ± 0.041 ms 0.108 ± 0.045 ms 0.915 ± 0.53
mtkcompile 11.4 ± 0.97 ms 10.4 ± 0.7 ms 1.09 ± 0.12
sparse_analytical_jacobian/ODEProblem 24.6 ± 1.1 ms 21.9 ± 1.6 ms 1.13 ± 0.094
sparse_analytical_jacobian/f_iip 0.07 ± 0 μs 0.07 ± 0 μs 1 ± 0
sparse_analytical_jacobian/f_oop 0.384 ± 0.012 ms 0.383 ± 0.017 ms 1 ± 0.054
time_to_load 6.74 ± 0.12 s 6.5 ± 0.071 s 1.04 ± 0.021
Memory benchmarks
master dcfff24... master / dcfff24...
ODEProblem 0.0368 M allocs: 1.92 MB 0.0368 M allocs: 1.92 MB 0.999
init 0.428 k allocs: 0.0725 MB 0.428 k allocs: 0.0725 MB 1
large_parameter_init/ODEProblem 0.159 M allocs: 5.99 MB 0.159 M allocs: 5.99 MB 1
large_parameter_init/init 0.616 k allocs: 0.175 MB 0.616 k allocs: 0.175 MB 1
mtkcompile 0.059 M allocs: 3.34 MB 0.059 M allocs: 3.35 MB 0.995
sparse_analytical_jacobian/ODEProblem 0.117 M allocs: 5.69 MB 0.117 M allocs: 5.69 MB 1
sparse_analytical_jacobian/f_iip 0 allocs: 0 B 0 allocs: 0 B
sparse_analytical_jacobian/f_oop 0.634 k allocs: 19.6 kB 0.634 k allocs: 19.6 kB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Benchmark Results (Julia v1)

Time benchmarks
master dcfff24... master / dcfff24...
ODEProblem 5.4 ± 0.21 ms 5.56 ± 0.29 ms 0.971 ± 0.064
init 0.0749 ± 0.019 ms 0.0748 ± 0.019 ms 1 ± 0.37
large_parameter_init/ODEProblem 15.1 ± 1.8 ms 16.4 ± 2.2 ms 0.923 ± 0.17
large_parameter_init/init 0.0975 ± 0.027 ms 0.0986 ± 0.031 ms 0.988 ± 0.41
mtkcompile 8.7 ± 0.44 ms 8.88 ± 0.53 ms 0.979 ± 0.076
sparse_analytical_jacobian/ODEProblem 19.1 ± 1.8 ms 19.1 ± 1.7 ms 0.998 ± 0.13
sparse_analytical_jacobian/f_iip 0.089 ± 0.01 μs 0.09 ± 0 μs 0.989 ± 0.11
sparse_analytical_jacobian/f_oop 0.145 ± 0.016 ms 0.144 ± 0.013 ms 1 ± 0.14
time_to_load 5.97 ± 0.1 s 6.01 ± 0.023 s 0.994 ± 0.017
Memory benchmarks
master dcfff24... master / dcfff24...
ODEProblem 0.0364 M allocs: 1.66 MB 0.0364 M allocs: 1.66 MB 1
init 0.426 k allocs: 0.0545 MB 0.426 k allocs: 0.0545 MB 1
large_parameter_init/ODEProblem 0.153 M allocs: 5.15 MB 0.153 M allocs: 5.15 MB 1
large_parameter_init/init 0.809 k allocs: 0.154 MB 0.809 k allocs: 0.154 MB 1
mtkcompile 0.0556 M allocs: 2.59 MB 0.0556 M allocs: 2.59 MB 1
sparse_analytical_jacobian/ODEProblem 0.117 M allocs: 4.75 MB 0.117 M allocs: 4.75 MB 1
sparse_analytical_jacobian/f_iip 0 allocs: 0 B 0 allocs: 0 B
sparse_analytical_jacobian/f_oop 0.848 k allocs: 27 kB 0.848 k allocs: 27 kB 1
time_to_load 0.145 k allocs: 11 kB 0.145 k allocs: 11 kB 1

@AayushSabharwal
AayushSabharwal merged commit 32a955a into master Aug 5, 2026
76 of 93 checks passed
@AayushSabharwal
AayushSabharwal deleted the as/get-sens-t branch August 5, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to get a sensitivity function at a nonzero linearization time? (t kwarg accepted but ignored, iv in op errors)

1 participant