Repository navigation
OptimizationNLopt: make imports explicit - #1398
Merged
ChrisRackauckas merged 1 commit intoOct 4, 2026
Merged
ChrisRackauckas merged 1 commit into
ChrisRackauckas merged 1 commit into
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Codex <noreply@openai.com> Agent-Harness: Codex CLI 0.160.0 Agent-Model: gpt-6-luna Agent-Session: local session, transcript at /home/crackauc/sandbox/goals/qa-hygiene/jobs/nlopt-imports/log.txt on amdci2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OptimizationNLopt now imports the NLopt, OptimizationBase, and SciMLBase module bindings and the individual names its implementation uses. The QA suite no longer marks
no_implicit_importsas broken, and the NLopt module,Algorithm,Opt,OptimizationCache, andReturnCodebindings remain available.Verification
The QA and Core commands below ran from
lib/OptimizationNLopt, with the Julia depot and temporary directory isolated under this job directory.Quality Assurance | 26 1 27 1m35.1s;Testing OptimizationNLopt tests passed.Quality Assurance | 27 27 1m33.5s;Testing OptimizationNLopt tests passed.Core | 42 42 1m36.0s;Testing OptimizationNLopt tests passed.julia --project=@runic -e 'using Runic; exit(Runic.main(ARGS))' -- --inplace lib/OptimizationNLopt/src/OptimizationNLopt.jl lib/OptimizationNLopt/test/qa/qa.jl— exit 0.typos lib/OptimizationNLopt/src/OptimizationNLopt.jl lib/OptimizationNLopt/test/qa/qa.jl— exit 0.lib/,test/, anddocs/for qualifiedOptimizationNLopt.xreferences. The only code use isOptimizationNLopt.Optinlib/OptimizationMultistartOptimization/test/core_tests.jl;Optremains explicitly imported. The QA reexport check passes.Not verified: CI, the full Optimization.jl monorepo suite, and downstream packages.
Please ignore this draft until reviewed by @ChrisRackauckas.
Risk assessment
OptimizationNLopt.Opt, still resolves toNLopt.Opt. Names that were only incidentally reachable asOptimizationNLopt.xthrough the old blanketusing(e.g.OptimizationNLopt.solve,OptimizationNLopt.AutoForwardDiff) no longer are; nothing inlib/,test/ordocs/uses them, but downstream code spelling them that way would break.gpt-6-astrarated it low risk, high confidence, verdict MERGE, after rerunning QA on base and head (26+1 broken → 27/27), Core (42/42) and a base/head binding comparison. It is the same harness as the author. Cross-harness: Claude Code (claude-opus-5-5[1m]) read the full diff and rated it low risk, high confidence, verdict MERGE.🤖 Generated with Codex CLI 0.160.0 (model: gpt-6-luna); transcript: /home/crackauc/sandbox/goals/qa-hygiene/jobs/nlopt-imports/log.txt