Skip to content

Remove the makeshadow inlining workaround once EnzymeAD/Enzyme.jl#3322 is fixed #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ChrisRackauckas-Claude wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Remove the makeshadow inlining workaround once EnzymeAD/Enzyme.jl#3322 is fixed #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions ext/PreallocationToolsEnzymeCoreExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,21 +50,10 @@ shadowkey(b::LazyBufferCache) = b.bufs

# `warn_on_resize = false`: the primal cache already warns if it is enlarged;
# a second warning from the hidden shadow cache would be confusing.
# `@inline`: under nested differentiation these run inside Enzyme-compiled
# code, and Enzyme's module type-classification cannot parse standalone
# functions returning immutable structs with mixed pointer/isbits fields on
# Julia <= 1.11 (sret+returnroots CallingConventionMismatchError); inlined
# into `constshadow` no such function exists in the module.
@inline makeshadow(dc::DiffCache) = DiffCache(
zero(dc.du), zero(dc.dual_du), Any[], false
)
@inline makeshadow(dc::FixedSizeDiffCache) = FixedSizeDiffCache(
zero(dc.du), zero(dc.dual_du), Any[]
)
makeshadow(dc::DiffCache) = DiffCache(zero(dc.du), zero(dc.dual_du), Any[], false)
makeshadow(dc::FixedSizeDiffCache) = zero(dc)
zeroinit!(buf) = fill!(buf, zero(eltype(buf)))
@inline makeshadow(b::LazyBufferCache) = LazyBufferCache(
b.sizemap; initializer! = zeroinit!
)
makeshadow(b::LazyBufferCache) = LazyBufferCache(b.sizemap; initializer! = zeroinit!)

shadowfits(s::DiffCache, dc::DiffCache) = size(s.du) == size(dc.du)
shadowfits(s::FixedSizeDiffCache, dc::FixedSizeDiffCache) = size(s.du) == size(dc.du)
Expand Down
Loading