Declare KLUFactorization public without a non-public Meta.parse call - #77
Merged
Conversation
QA is red on master: `eval(Meta.parse("public KLUFactorization"))`
reaches `Base.Meta.parse`, which is not public, so ExplicitImports'
`all_qualified_accesses_are_public` errors out.
`include_string` is exported by Base and does the same job.
`KLUFactorization` stays unexported and `public` on Julia >= 1.11.
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DR4AenbZvWqp2BMM42T27A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Please ignore until reviewed by @ChrisRackauckas.
Problem
QA is currently red on main.
src/PureKLU.jl:34declaresKLUFactorizationpublic withMeta.parseis not public inBase.Meta, so ExplicitImports'all_qualified_accesses_are_publicerrors:Reproduced on a clean checkout of main with
GROUP=QAon Julia 1.11.I hit this because I copied the idiom into PureUMFPACK (SciML/PureUMFPACK.jl#36) and its QA rejected it there.
Fix
Use
include_string, which is exported by Base and does the same job:KLUFactorizationremains unexported andpublicon Julia >= 1.11 — verifiedBase.isexported(PureKLU, :KLUFactorization) == falseandBase.ispublic(PureKLU, :KLUFactorization) == trueafter the change.Verification
Julia 1.11:
GROUP=QATesting PureKLU tests passedPkg.test()(Core)Testing PureKLU tests passedNo version bump: the two forms are behaviorally identical, so this is a lint/QA fix with no user-visible change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DR4AenbZvWqp2BMM42T27A