Updated CA Profiles content #5
Open
sammypops wants to merge 27 commits intoScotGovAnalysis:masterfrom
Open
Conversation
…gether a developing object
… accepts them as list in the input parameters
Save them into RDS format. Rmd now reads the RDS file for data instead of passing in hundreds of megabytes as a parameter to the knitting process.
…brary, functions take more variables in circumstances where they relied on elements being available in the global env. Content production is split from definitions of production functions.
…ults of the checks. Console output is now limited to summary data. This reduces screen clutter. And the automated table join messages are suppressed to reduce clutter in the console too. Making it easier to see when data expectations are not being met.
…es wrong and the number of pieces of content is different the knitting will not go ahead and the user will be prompted to check the output
… stage. Solution needs some thought. Comments are left to indicate the issue
Too much depends on it being this way and a full refactoring isn't worth doing at this point.
-missing 'temp' folder -knitting failing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• Added proj file
• Set up folder to hold scripts which define custom functions for project
• Moved content production scripts out of markdown document into a set of functions which produce all variable content
• Content production now occurs before markdown is knitted and stored on disk
• Content production parallelised
• Variable content saved to file is loaded by the markdown instead of being run in situ
• Markdown rendering parallelised
• Moved functions into separate folder
• Added extra arguments to functions which relied on global variables in scope
• Moved content production scripts to own folder
• Added new args to function calls in content production
• Made old global variables visible to scope of content production
• Simplified content production into single step at high level
• Added lots of comments to describe intention of code
• Flow of code execution is now signposted with comments