Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renames the host virtual environment directory from installer_venv to anthias_venv #1960

Closed
wants to merge 1 commit into from
Closed

Renames the host virtual environment directory from installer_venv to anthias_venv #1960

wants to merge 1 commit into from

Conversation

nicomiguelino
Copy link
Contributor

Description

  • The rename signifies that the virtual environment will primarily contain the dependencies needed by the host, especially the helper scripts.

@nicomiguelino nicomiguelino requested a review from a team as a code owner July 5, 2024 22:14
vpetersson
vpetersson requested changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@vpetersson vpetersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it makes sense to switch to Poetry instead if we are going to touch this?

@nicomiguelino
Copy link
Contributor Author

Closing this pull request in favor of #1969

@nicomiguelino nicomiguelino deleted the modify-installer branch July 11, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpetersson vpetersson vpetersson requested changes

Assignees
No one assigned
Labels
None yet
Projects
Anthias
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicomiguelino @vpetersson