-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't return on error #51
Conversation
Remove extra quotation marks.
…-plugin into no-return-on-error
Now that errors are only returned in truly exceptional cases, |
Ok, all issues seem to be settled. |
…-plugin into no-return-on-error
isMounted returning false does not guarantee that the drive letter has been removed.
Describe your changes in brief
Returning an error from
settingsReceived()
stops the UI from functioning normally, sosettingsReceived()
should only return an error when it can't return a validSettingsResponse
.This PR also includes some refactoring:
settingsReceived()
into multiple functions to improve readabilityEngine
superclass (in helpers), into our inheriting class.m_
prefix for class member fields.What type of Pull Request is this? (check all applicable)
Checklist
Related Issues