Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bat script to fail on Windows if unable to compile #73

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

jfantinhardesty
Copy link
Contributor

What type of Pull Request is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Describe your changes in brief

If the plugin fails on windows, it does not fail with an error code, which prevents our GitHub actions from detecting a failure. This fixes that issue.

Checklist

  • Tested locally
  • Added new dependencies
  • Updated documentation
  • Added tests

Related Issues

  • Related Issue #
  • Closes #

@jfantinhardesty jfantinhardesty merged commit b8eda4d into main Feb 4, 2025
11 of 12 checks passed
@jfantinhardesty jfantinhardesty deleted the fix-plugin-fail-windows branch February 4, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants