fix(l10n): mark missing strings for translation #867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdmukai
reviewed
Jan 17, 2026
kdmukai
reviewed
Jan 17, 2026
| SettingsEntry(category=SettingsConstants.CATEGORY__FEATURES, | ||
| attr_name=SettingsConstants.SETTING__MICROSD_TOAST_TIMER, | ||
| display_name="MicroSD toast timer", | ||
| display_name=_mft("MicroSD toast timer"), |
Contributor
There was a problem hiding this comment.
Before we add this as a translation string, I think the "toast" terminology should be removed. I had never heard that UX term before until Easy introduced it (like, seriously, who in the UX world came up with that as a term?! It's absurd).
I don't think a typical user would be familiar with it, either. And I don't think translators should have to struggle with it.
So this is expanding the scope of this PR slightly, but I'd prefer renaming it to something like "MicroSD reminder". "MicroSD notification"?
Contributor
Author
There was a problem hiding this comment.
I've renamed the setting string to "MicroSD notification duration".
kdmukai
reviewed
Jan 17, 2026
Contributor
|
These are great catches! |
Chaitanya-Keyal
force-pushed
the
fix/missing-l10n
branch
2 times, most recently
from
f550968 to
76814e2
Compare
Co-authored-by: kdmukai <[email protected]>
Chaitanya-Keyal
force-pushed
the
fix/missing-l10n
branch
from
76814e2 to
553cdb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR marks previously unmarked user facing strings for translation. I noticed these issues while reviewing the Hindi translations in SeedSigner/seedsigner-translations#54.
Summary of Changes
_mft()so they are included in translation extractiongettext(_()) inNetworkMismatchErrorViewmessages.potto include these strings, along with other recent changes already merged intodevScreens affected (Hindi screenshots)
Missing strings in MicroSD Toast Timer (now, "MicroSD notification duration")
NetworkMismatchErrorView
Before: Network value rendered without translation
After: Network value correctly translated
This pull request is categorized as a:
l10n)Checklist
pytestand made sure all unit tests pass before submitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os: