Squashed commit of the following:

commit 34c56c6
Merge: ae67290 86503a2
Author: Slava Krutelyov <[email protected]>
Date:   Tue Jul 9 16:29:56 2024 -0700

    Merge pull request #49 from SegmentLinking/ESProducer_fixes

    ESProducer fixes

commit ae67290
Author: Manos Vourliotis <[email protected]>
Date:   Tue Jul 9 06:07:31 2024 -0700

    Simplify LST workflows

commit 7cfe3a5
Author: Manos Vourliotis <[email protected]>
Date:   Tue Jul 9 06:06:39 2024 -0700

    Code format and checks

commit a3a8054
Author: Manos Vourliotis <[email protected]>
Date:   Tue Jul 9 05:19:42 2024 -0700

    Even further work on naming values and sqrt, loop, etc. simplifications

commit 86503a2
Author: Andres Rios Tascon <[email protected]>
Date:   Mon Jul 8 07:41:35 2024 -0700

    Fixed include guards for headers in interface directory

commit f47212f
Author: Andres Rios Tascon <[email protected]>
Date:   Mon Jul 8 07:32:46 2024 -0700

    Renamed new endcap geometry class

commit d3e5999
Merge: f46b6cb c563eb0
Author: Andres Rios Tascon <[email protected]>
Date:   Mon Jul 8 08:07:27 2024 -0700

    Merge remote-tracking branch 'SegLink/CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_batch3' into ESProducer_fixes

commit c563eb0
Author: Manos Vourliotis <[email protected]>
Date:   Mon Jul 8 07:39:49 2024 -0700

    Further work on naming values and sqrt, loop, etc. simplifications

commit 4d7e54a
Merge: a97714a dc13ac5
Author: Slava Krutelyov <[email protected]>
Date:   Fri Jul 5 09:15:23 2024 -0700

    Merge pull request #58 from SegmentLinking/remove_LST_IS_CMSSW_PACKAGE

    combo of: Remove LST_IS_CMSSW_PACKAGE (#47), configurable dup cleaning (#37), typo in T3 code (#44)

commit a97714a
Author: Manos Vourliotis <[email protected]>
Date:   Wed Jul 3 07:16:19 2024 -0700

    Apply reco comments: Naming values and sqrt, loop, etc. simplifications

commit 236ad8c
Author: Manos Vourliotis <[email protected]>
Date:   Sat Jun 29 02:43:48 2024 -0700

    Simplification of sqrt operations for pT3s

commit 149c628
Author: Manos Vourliotis <[email protected]>
Date:   Fri Jun 28 21:23:31 2024 +0200

    Resolve conflicts regarding workflows

commit f46b6cb
Author: Andres Rios Tascon <[email protected]>
Date:   Mon Jun 24 12:52:12 2024 -0700

    Removed -Wshadow flag

commit eb5de05
Author: Andres Rios Tascon <[email protected]>
Date:   Mon Jun 24 11:30:45 2024 -0700

    Minor cleanup

commit a3f65da
Author: Andres Rios Tascon <[email protected]>
Date:   Mon Jun 24 11:00:13 2024 -0700

    Separated EndcapGeometry into host-only and buffers struct

commit ef48f74
Author: Manos Vourliotis <[email protected]>
Date:   Mon Jun 24 02:21:11 2024 -0700

    Removal of gpu modifier from LST workflows

commit e0acfa5
Author: Andres Rios Tascon <[email protected]>
Date:   Tue Jun 18 10:40:38 2024 -0700

    Addressed ESProducer comments

commit 4cd8924
Author: Slava Krutelyov <[email protected]>
Date:   Fri Jun 14 18:00:59 2024 -0700

    code-format/checks

commit e64c2cc
Merge: 314e95d 3552ad3
Author: Slava Krutelyov <[email protected]>
Date:   Fri Jun 14 17:45:17 2024 -0700

    Merge pull request #38 from SegmentLinking/CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_batch2

    Batch 2 for updates to LST integration in cms-sw

commit 3552ad3
Author: Manos Vourliotis <[email protected]>
Date:   Thu Jun 13 09:42:00 2024 -0700

    Fixing CMS coding rule 1

commit 944652f
Author: Manos Vourliotis <[email protected]>
Date:   Tue Jun 11 01:17:16 2024 +0200

    Keep comment closer to the added task object

    Co-authored-by: Slava Krutelyov <[email protected]>

commit 85682e8
Author: Manos Vourliotis <[email protected]>
Date:   Mon Jun 10 09:08:42 2024 -0700

    Resolving PR comments LST folder

Configuration/PyReleaseValidation/README.md

@@ -61,6 +61,8 @@ The offsets currently in use are:
 * 0.7: trackingMkFit modifier
 * 0.701: DisplacedRegionalStep tracking iteration for Run-3
 * 0.702: trackingMkFit modifier for Phase-2 (initialStep only)
+* 0.703: LST tracking, initialStep+HighPtTripletStep only, on CPU
+* 0.704: LST tracking, initialStep+HighPtTripletStep only, on GPU
 * 0.78: Complete L1 workflow
 * 0.8: BPH Parking (Run-2)
 * 0.81: Running also HeavyFlavor DQM

Configuration/PyReleaseValidation/python/relval_2026.py

@@ -26,7 +26,6 @@
 numWFIB.extend([24834.0,24834.911,24834.103]) #2026D98 DDD XML, DD4hep XML, aging
 numWFIB.extend([25061.97]) #2026D98 premixing stage1 (NuGun+PU)
 numWFIB.extend([24834.702]) #2026D98 mkFit tracking (initialStep)
-numWFIB.extend([24834.703,24834.704]) #2026D98 LST tracking (initialStep+HighPtTripletStep only): CPU, GPU
 numWFIB.extend([24834.5,24834.9]) #2026D98 pixelTrackingOnly, vector hits
 numWFIB.extend([24834.501,24834.502]) #2026D98 Patatrack local reconstruction on CPU, Patatrack local reconstruction on GPU
 numWFIB.extend([25034.99,25034.999]) #2026D98 premixing combined stage1+stage2 (ttbar+PU200, ttbar+PU50 for PR test)
@@ -55,5 +54,8 @@
 # NuGun 
 numWFIB.extend([24861.0]) #Nu Gun 2026D98
 
+# Temporary placement for LST workflow to workaround PR conflicts - to be formatted and placed in an upcoming PR
+numWFIB.extend([24834.703,24834.704]) #2026D98 LST tracking (initialStep+HighPtTripletStep only): CPU, GPU
+
 for numWF in numWFIB:
     workflows[numWF] = _upgrade_workflows[numWF]

Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py

@@ -485,16 +485,8 @@ def condition_(self, fragment, stepList, key, hasHarvest):
         return ('2026' in key)
 upgradeWFs['lstOnCPUIters01TrackingOnly'] = UpgradeWorkflow_lstOnCPUIters01TrackingOnly(
     steps = [
-        'Reco',
-        'RecoFakeHLT',
-        'HARVEST',
-        'HARVESTFakeHLT',
         'RecoGlobal',
         'HARVESTGlobal',
-        'RecoNano',
-        'RecoNanoFakeHLT',
-        'HARVESTNano',
-        'HARVESTNanoFakeHLT',
         # Add ALCA steps explicitly, so that they can be properly removed
         'ALCA',
         'ALCAPhase2'
@@ -504,7 +496,8 @@ def condition_(self, fragment, stepList, key, hasHarvest):
     offset = 0.703,
 )
 upgradeWFs['lstOnCPUIters01TrackingOnly'].step3 = upgradeWFs['trackingOnly'].step3 | {
-    '--procModifiers': 'trackingIters01,trackingLST'
+    '--procModifiers': 'trackingIters01,trackingLST',
+    '--accelerators' : 'cpu'
 }
 
 # LST on GPU, initialStep+highPtTripletStep-only tracking-only
@@ -517,16 +510,8 @@ def condition_(self, fragment, stepList, key, hasHarvest):
         return ('2026' in key)
 upgradeWFs['lstOnGPUIters01TrackingOnly'] = UpgradeWorkflow_lstOnGPUIters01TrackingOnly(
     steps = [
-        'Reco',
-        'RecoFakeHLT',
-        'HARVEST',
-        'HARVESTFakeHLT',
         'RecoGlobal',
         'HARVESTGlobal',
-        'RecoNano',
-        'RecoNanoFakeHLT',
-        'HARVESTNano',
-        'HARVESTNanoFakeHLT',
         # Add ALCA steps explicitly, so that they can be properly removed
         'ALCA',
         'ALCAPhase2'
@@ -536,7 +521,8 @@ def condition_(self, fragment, stepList, key, hasHarvest):
     offset = 0.704,
 )
 upgradeWFs['lstOnGPUIters01TrackingOnly'].step3 = upgradeWFs['trackingOnly'].step3 | {
-    '--procModifiers': 'gpu,trackingIters01,trackingLST'
+    '--procModifiers': 'trackingIters01,trackingLST',
+    '--accelerators' : 'gpu-nvidia'
 }
 
 #DeepCore seeding for JetCore iteration workflow

RecoTracker/IterativeTracking/python/HighPtTripletStep_cff.py

@@ -425,7 +425,7 @@
 
 _HighPtTripletStepTask_LST = HighPtTripletStepTask.copy()
 from RecoLocalTracker.Phase2TrackerRecHits.Phase2TrackerRecHits_cfi import siPhase2RecHits
-from RecoTracker.LST.lstSeedTracks_cfi import lstInitialStepSeedTracks,lstHighPtTripletStepSeedTracks
+from RecoTracker.LST.lstSeedTracks_cff import lstInitialStepSeedTracks,lstHighPtTripletStepSeedTracks
 from RecoTracker.LST.lstPixelSeedInputProducer_cfi import lstPixelSeedInputProducer
 from RecoTracker.LST.lstPhase2OTHitsInputProducer_cfi import lstPhase2OTHitsInputProducer
 from RecoTracker.LST.lstProducer_cff import *

RecoTracker/LST/interface/LSTOutput.h

@@ -1,26 +1,26 @@
-#ifndef RecoTracker_LST_LSTOutput_h
-#define RecoTracker_LST_LSTOutput_h
+#ifndef RecoTracker_LST_interface_LSTOutput_h
+#define RecoTracker_LST_interface_LSTOutput_h
 
 #include <memory>
 #include <vector>
 
 class LSTOutput {
 public:
   LSTOutput() = default;
+  LSTOutput(std::vector<std::vector<unsigned int>> hitIdx,
+            std::vector<unsigned int> len,
+            std::vector<int> seedIdx,
+            std::vector<short> trackCandidateType) {
+    hitIdx_ = std::move(hitIdx);
+    len_ = std::move(len);
+    seedIdx_ = std::move(seedIdx);
+    trackCandidateType_ = std::move(trackCandidateType);
+  }
+
   ~LSTOutput() = default;
 
   enum LSTTCType { T5 = 4, pT3 = 5, pT5 = 7, pLS = 8 };
 
-  void setLSTOutputTraits(std::vector<std::vector<unsigned int>> hitIdx,
-                          std::vector<unsigned int> len,
-                          std::vector<int> seedIdx,
-                          std::vector<short> trackCandidateType) {
-    hitIdx_ = hitIdx;
-    len_ = len;
-    seedIdx_ = seedIdx;
-    trackCandidateType_ = trackCandidateType;
-  }
-
   std::vector<std::vector<unsigned int>> const& hitIdx() const { return hitIdx_; }
   std::vector<unsigned int> const& len() const { return len_; }
   std::vector<int> const& seedIdx() const { return seedIdx_; }

RecoTracker/LST/interface/LSTPhase2OTHitsInput.h

@@ -1,5 +1,5 @@
-#ifndef RecoTracker_LST_LSTPhase2OTHitsInput_h
-#define RecoTracker_LST_LSTPhase2OTHitsInput_h
+#ifndef RecoTracker_LST_interface_LSTPhase2OTHitsInput_h
+#define RecoTracker_LST_interface_LSTPhase2OTHitsInput_h
 
 #include <memory>
 #include <vector>
@@ -9,20 +9,20 @@
 class LSTPhase2OTHitsInput {
 public:
   LSTPhase2OTHitsInput() = default;
-  ~LSTPhase2OTHitsInput() = default;
-
-  void setLSTPhase2OTHitsTraits(std::vector<unsigned int> detId,
-                                std::vector<float> x,
-                                std::vector<float> y,
-                                std::vector<float> z,
-                                std::vector<TrackingRecHit const*> hits) {
-    detId_ = detId;
-    x_ = x;
-    y_ = y;
-    z_ = z;
-    hits_ = hits;
+  LSTPhase2OTHitsInput(std::vector<unsigned int> detId,
+                       std::vector<float> x,
+                       std::vector<float> y,
+                       std::vector<float> z,
+                       std::vector<TrackingRecHit const*> hits) {
+    detId_ = std::move(detId);
+    x_ = std::move(x);
+    y_ = std::move(y);
+    z_ = std::move(z);
+    hits_ = std::move(hits);
   }
 
+  ~LSTPhase2OTHitsInput() = default;
+
   std::vector<unsigned int> const& detId() const { return detId_; }
   std::vector<float> const& x() const { return x_; }
   std::vector<float> const& y() const { return y_; }

RecoTracker/LST/interface/LSTPixelSeedInput.h

@@ -1,46 +1,46 @@
-#ifndef RecoTracker_LST_LSTPixelSeedInput_h
-#define RecoTracker_LST_LSTPixelSeedInput_h
+#ifndef RecoTracker_LST_interface_LSTPixelSeedInput_h
+#define RecoTracker_LST_interface_LSTPixelSeedInput_h
 
 #include <memory>
 #include <vector>
 
 class LSTPixelSeedInput {
 public:
   LSTPixelSeedInput() = default;
-  ~LSTPixelSeedInput() = default;
-
-  void setLSTPixelSeedTraits(std::vector<float> px,
-                             std::vector<float> py,
-                             std::vector<float> pz,
-                             std::vector<float> dxy,
-                             std::vector<float> dz,
-                             std::vector<float> ptErr,
-                             std::vector<float> etaErr,
-                             std::vector<float> stateTrajGlbX,
-                             std::vector<float> stateTrajGlbY,
-                             std::vector<float> stateTrajGlbZ,
-                             std::vector<float> stateTrajGlbPx,
-                             std::vector<float> stateTrajGlbPy,
-                             std::vector<float> stateTrajGlbPz,
-                             std::vector<int> q,
-                             std::vector<std::vector<int>> hitIdx) {
-    px_ = px;
-    py_ = py;
-    pz_ = pz;
-    dxy_ = dxy;
-    dz_ = dz;
-    ptErr_ = ptErr;
-    etaErr_ = etaErr;
-    stateTrajGlbX_ = stateTrajGlbX;
-    stateTrajGlbY_ = stateTrajGlbY;
-    stateTrajGlbZ_ = stateTrajGlbZ;
-    stateTrajGlbPx_ = stateTrajGlbPx;
-    stateTrajGlbPy_ = stateTrajGlbPy;
-    stateTrajGlbPz_ = stateTrajGlbPz;
-    q_ = q;
-    hitIdx_ = hitIdx;
+  LSTPixelSeedInput(std::vector<float> px,
+                    std::vector<float> py,
+                    std::vector<float> pz,
+                    std::vector<float> dxy,
+                    std::vector<float> dz,
+                    std::vector<float> ptErr,
+                    std::vector<float> etaErr,
+                    std::vector<float> stateTrajGlbX,
+                    std::vector<float> stateTrajGlbY,
+                    std::vector<float> stateTrajGlbZ,
+                    std::vector<float> stateTrajGlbPx,
+                    std::vector<float> stateTrajGlbPy,
+                    std::vector<float> stateTrajGlbPz,
+                    std::vector<int> q,
+                    std::vector<std::vector<int>> hitIdx) {
+    px_ = std::move(px);
+    py_ = std::move(py);
+    pz_ = std::move(pz);
+    dxy_ = std::move(dxy);
+    dz_ = std::move(dz);
+    ptErr_ = std::move(ptErr);
+    etaErr_ = std::move(etaErr);
+    stateTrajGlbX_ = std::move(stateTrajGlbX);
+    stateTrajGlbY_ = std::move(stateTrajGlbY);
+    stateTrajGlbZ_ = std::move(stateTrajGlbZ);
+    stateTrajGlbPx_ = std::move(stateTrajGlbPx);
+    stateTrajGlbPy_ = std::move(stateTrajGlbPy);
+    stateTrajGlbPz_ = std::move(stateTrajGlbPz);
+    q_ = std::move(q);
+    hitIdx_ = std::move(hitIdx);
   }
 
+  ~LSTPixelSeedInput() = default;
+
   std::vector<float> const& px() const { return px_; }
   std::vector<float> const& py() const { return py_; }
   std::vector<float> const& pz() const { return pz_; }

RecoTracker/LST/plugins/LSTOutputConverter.cc

@@ -41,8 +41,8 @@ class LSTOutputConverter : public edm::global::EDProducer<> {
   const bool includeT5s_;
   const bool includeNonpLSTSs_;
   const edm::ESGetToken<MagneticField, IdealMagneticFieldRecord> mfToken_;
-  edm::ESGetToken<Propagator, TrackingComponentsRecord> propagatorAlongToken_;
-  edm::ESGetToken<Propagator, TrackingComponentsRecord> propagatorOppositeToken_;
+  const edm::ESGetToken<Propagator, TrackingComponentsRecord> propagatorAlongToken_;
+  const edm::ESGetToken<Propagator, TrackingComponentsRecord> propagatorOppositeToken_;
   const edm::ESGetToken<TrackerGeometry, TrackerDigiGeometryRecord> tGeomToken_;
   std::unique_ptr<SeedCreator> seedCreator_;
   const edm::EDPutTokenT<TrajectorySeedCollection> trajectorySeedPutToken_;
@@ -57,11 +57,9 @@ class LSTOutputConverter : public edm::global::EDProducer<> {
 };
 
 LSTOutputConverter::LSTOutputConverter(edm::ParameterSet const& iConfig)
-    : lstOutputToken_(consumes<LSTOutput>(iConfig.getUntrackedParameter<edm::InputTag>("lstOutput"))),
-      lstPhase2OTHitsInputToken_{
-          consumes<LSTPhase2OTHitsInput>(iConfig.getUntrackedParameter<edm::InputTag>("phase2OTHits"))},
-      lstPixelSeedToken_{
-          consumes<TrajectorySeedCollection>(iConfig.getUntrackedParameter<edm::InputTag>("lstPixelSeeds"))},
+    : lstOutputToken_(consumes<LSTOutput>(iConfig.getParameter<edm::InputTag>("lstOutput"))),
+      lstPhase2OTHitsInputToken_{consumes<LSTPhase2OTHitsInput>(iConfig.getParameter<edm::InputTag>("phase2OTHits"))},
+      lstPixelSeedToken_{consumes<TrajectorySeedCollection>(iConfig.getParameter<edm::InputTag>("lstPixelSeeds"))},
       includeT5s_(iConfig.getParameter<bool>("includeT5s")),
       includeNonpLSTSs_(iConfig.getParameter<bool>("includeNonpLSTSs")),
       mfToken_(esConsumes()),
@@ -92,9 +90,9 @@ LSTOutputConverter::LSTOutputConverter(edm::ParameterSet const& iConfig)
 void LSTOutputConverter::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
   edm::ParameterSetDescription desc;
 
-  desc.addUntracked<edm::InputTag>("lstOutput", edm::InputTag("lstProducer"));
-  desc.addUntracked<edm::InputTag>("phase2OTHits", edm::InputTag("lstPhase2OTHitsInputProducer"));
-  desc.addUntracked<edm::InputTag>("lstPixelSeeds", edm::InputTag("lstPixelSeedInputProducer"));
+  desc.add<edm::InputTag>("lstOutput", edm::InputTag("lstProducer"));
+  desc.add<edm::InputTag>("phase2OTHits", edm::InputTag("lstPhase2OTHitsInputProducer"));
+  desc.add<edm::InputTag>("lstPixelSeeds", edm::InputTag("lstPixelSeedInputProducer"));
   desc.add<bool>("includeT5s", true);
   desc.add<bool>("includeNonpLSTSs", false);
   desc.add("propagatorAlong", edm::ESInputTag{"", "PropagatorWithMaterial"});

RecoTracker/LST/plugins/LSTPhase2OTHitsInputProducer.cc

@@ -21,14 +21,14 @@ class LSTPhase2OTHitsInputProducer : public edm::global::EDProducer<> {
 };
 
 LSTPhase2OTHitsInputProducer::LSTPhase2OTHitsInputProducer(edm::ParameterSet const& iConfig)
-    : phase2OTRecHitToken_(consumes<Phase2TrackerRecHit1DCollectionNew>(
-          iConfig.getUntrackedParameter<edm::InputTag>("phase2OTRecHits"))),
+    : phase2OTRecHitToken_(
+          consumes<Phase2TrackerRecHit1DCollectionNew>(iConfig.getParameter<edm::InputTag>("phase2OTRecHits"))),
       lstPhase2OTHitsInputPutToken_(produces<LSTPhase2OTHitsInput>()) {}
 
 void LSTPhase2OTHitsInputProducer::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
   edm::ParameterSetDescription desc;
 
-  desc.addUntracked<edm::InputTag>("phase2OTRecHits", edm::InputTag("siPhase2RecHits"));
+  desc.add<edm::InputTag>("phase2OTRecHits", edm::InputTag("siPhase2RecHits"));
 
   descriptions.addWithDefaultLabel(desc);
 }
@@ -38,8 +38,6 @@ void LSTPhase2OTHitsInputProducer::produce(edm::StreamID iID, edm::Event& iEvent
   auto const& phase2OTHits = iEvent.get(phase2OTRecHitToken_);
 
   // Vector definitions
-  LSTPhase2OTHitsInput phase2OTHitsInput;
-
   std::vector<unsigned int> ph2_detId;
   std::vector<float> ph2_x;
   std::vector<float> ph2_y;
@@ -57,7 +55,7 @@ void LSTPhase2OTHitsInputProducer::produce(edm::StreamID iID, edm::Event& iEvent
     }
   }
 
-  phase2OTHitsInput.setLSTPhase2OTHitsTraits(ph2_detId, ph2_x, ph2_y, ph2_z, ph2_hits);
+  LSTPhase2OTHitsInput phase2OTHitsInput(ph2_detId, ph2_x, ph2_y, ph2_z, ph2_hits);
   iEvent.emplace(lstPhase2OTHitsInputPutToken_, std::move(phase2OTHitsInput));
 }
 

RecoTracker/LST/plugins/LSTPixelSeedInputProducer.cc

@@ -39,22 +39,21 @@ class LSTPixelSeedInputProducer : public edm::global::EDProducer<> {
 
 LSTPixelSeedInputProducer::LSTPixelSeedInputProducer(edm::ParameterSet const& iConfig)
     : mfToken_(esConsumes()),
-      beamSpotToken_(consumes<reco::BeamSpot>(iConfig.getUntrackedParameter<edm::InputTag>("beamSpot"))),
+      beamSpotToken_(consumes<reco::BeamSpot>(iConfig.getParameter<edm::InputTag>("beamSpot"))),
       lstPixelSeedInputPutToken_(produces<LSTPixelSeedInput>()),
       lstPixelSeedsPutToken_(produces<TrajectorySeedCollection>()) {
-  seedTokens_ = edm::vector_transform(iConfig.getUntrackedParameter<std::vector<edm::InputTag>>("seedTracks"),
+  seedTokens_ = edm::vector_transform(iConfig.getParameter<std::vector<edm::InputTag>>("seedTracks"),
                                       [&](const edm::InputTag& tag) { return consumes<edm::View<reco::Track>>(tag); });
 }
 
 void LSTPixelSeedInputProducer::fillDescriptions(edm::ConfigurationDescriptions& descriptions) {
   edm::ParameterSetDescription desc;
 
-  desc.addUntracked<edm::InputTag>("beamSpot", edm::InputTag("offlineBeamSpot"));
+  desc.add<edm::InputTag>("beamSpot", edm::InputTag("offlineBeamSpot"));
 
-  desc.addUntracked<std::vector<edm::InputTag>>(
-      "seedTracks",
-      std::vector<edm::InputTag>{edm::InputTag("lstInitialStepSeedTracks"),
-                                 edm::InputTag("lstHighPtTripletStepSeedTracks")});
+  desc.add<std::vector<edm::InputTag>>("seedTracks",
+                                       std::vector<edm::InputTag>{edm::InputTag("lstInitialStepSeedTracks"),
+                                                                  edm::InputTag("lstHighPtTripletStepSeedTracks")});
 
   descriptions.addWithDefaultLabel(desc);
 }
@@ -65,7 +64,6 @@ void LSTPixelSeedInputProducer::produce(edm::StreamID iID, edm::Event& iEvent, c
   auto const& bs = iEvent.get(beamSpotToken_);
 
   // Vector definitions
-  LSTPixelSeedInput pixelSeedInput;
   std::vector<float> see_px;
   std::vector<float> see_py;
   std::vector<float> see_pz;
@@ -151,21 +149,21 @@ void LSTPixelSeedInputProducer::produce(edm::StreamID iID, edm::Event& iEvent, c
     }
   }
 
-  pixelSeedInput.setLSTPixelSeedTraits(see_px,
-                                       see_py,
-                                       see_pz,
-                                       see_dxy,
-                                       see_dz,
-                                       see_ptErr,
-                                       see_etaErr,
-                                       see_stateTrajGlbX,
-                                       see_stateTrajGlbY,
-                                       see_stateTrajGlbZ,
-                                       see_stateTrajGlbPx,
-                                       see_stateTrajGlbPy,
-                                       see_stateTrajGlbPz,
-                                       see_q,
-                                       see_hitIdx);
+  LSTPixelSeedInput pixelSeedInput(see_px,
+                                   see_py,
+                                   see_pz,
+                                   see_dxy,
+                                   see_dz,
+                                   see_ptErr,
+                                   see_etaErr,
+                                   see_stateTrajGlbX,
+                                   see_stateTrajGlbY,
+                                   see_stateTrajGlbZ,
+                                   see_stateTrajGlbPx,
+                                   see_stateTrajGlbPy,
+                                   see_stateTrajGlbPz,
+                                   see_q,
+                                   see_hitIdx);
   iEvent.emplace(lstPixelSeedInputPutToken_, std::move(pixelSeedInput));
   iEvent.emplace(lstPixelSeedsPutToken_, std::move(see_seeds));
 }