-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime pT input + low pT occupancies (rebase PR39 and PR54) #130
Runtime pT input + low pT occupancies (rebase PR39 and PR54) #130
Conversation
Co-authored-by: Gavin Niendorf <[email protected]>
Oops, fixed it.
I checked and there are no conflicts between them. |
Yeah I agree with moving it to another repo, no reason to include it in CMSSW. Same with the DNN training notebook, but maybe other people have different opinions. |
I checked on MM, it sounds like there is some support to have notebooks for documentation. ( I mentioned ~< 1MB size) |
I tried using https://gist.github.com/ariostas/91c12257271a72cbd2245a0a9d99043b |
Co-authored-by: Gavin Niendorf <[email protected]>
481be3a
to
8f56da4
Compare
/run all |
The PR was built and ran successfully in standalone mode. Here are some of the comparison plots.
The full set of validation and comparison plots can be found here. Here is a timing comparison:
|
The PR was built and ran successfully with CMSSW. Here are some plots. OOTB All Tracks
The full set of validation and comparison plots can be found here. |
ac2e345
into
CMSSW_14_1_0_pre3_LST_X_LSTCore_realfiles_batch1_devel_rebased
This is a rebase of PRs #39 and #54. They both deal with pt cutoffs, so I grouped them together.
One thing we have to think is whether adding the notebook would be okay for CMSSW since it's a relatively large file (2.4MB). I think maybe we should move it to another SegmentLinking repo or at least strip out the outputs.