-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batch 1 for updates to LST integration in cms-sw #34
batch 1 for updates to LST integration in cms-sw #34
Conversation
cms-data should be in the 2300 IB today. While I did not get a response from Matti on the fix proposed in #35 , the comments in the cms-sw PR were in line with this solution be more preferred than the others (accelerators_cff or makeProcessModifier). So, I wanted to propose to add #35 to this "batch 1". We can already merge this "batch 1" into the cms-sw PR some time as early as this evening CA time. Anything else we expect to have ready by then or if need to wait, by the meeting time tomorrow? |
Fine by me.
Fine by me as well. The only additional updates I can push right now is the deletion of the (outdated) test scripts and the (outdated) README. Other than that, I wanted to deal with some of the first comments but I am not sure I will manage to do it today/early tomorrow, and they are not super important for now. |
@slava77 I am done for this batch. |
@@ -1,42 +0,0 @@ | |||
# LSTCore proof of concept |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a readme may be still useful for self-documentation. The content removed here is probably good to go, but we need to eventually add something up to date.
The standalone/README is outdated as well; another to-do "soon"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the general README, let's discuss the content tomorrow at the meeting.
For the standalone one, I can draft an update when I port my SegmentLinking/TrackLooper#408 PR in the cmssw repo and run everything, and Andres can finalize with the details of the CI when these are settled.
accumulated list of features in the batch:
lstModulesDevESProducer
by attaching it to an unused task by default to get the framework to skip it (not construct) when LST is not used. This fixes unit tests failing withUnable to find plugin 'LSTModulesDevESProducer@alpaka'