chore: replace println with tracing::info#173
Merged
Conversation
Noticed in a few places that we were using println instead of info. When starting reth with --quiet, the printlns are still present: ``` Running `target/debug/seismic-reth node --dev --dev.block-time 2s --http --http.port 8545 --ws --ws.port 8545 --enclave.mock-server --quiet` TDX Quote JSON-RPC Server started at 0.0.0.0:7878 ``` Switching to info allows binaries that import the enclave lib to turn off the logs when they dont want them.
Contributor
Author
|
ci integration test is failing because of missing multisig in genesis file. Dalton told me it was fine to bypass. Test suite should prob be updated. |
samlaf
added a commit
to SeismicSystems/seismic-reth
that referenced
this pull request
Feb 25, 2026
Just a small change where enclave uses tracing instead of println so that --quiet actually doesnt show the enclave logs. Only incorporates this one commit: SeismicSystems/enclave#173
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed in a few places that we were using println instead of info. When starting reth with --quiet, the printlns are still present:
Switching to info allows binaries that import the enclave lib to turn off the logs when they dont want them.