feat: get rid of seismic-trie fork#328
Closed
samlaf wants to merge 4 commits intoveridise-audit-feb-2026from
Closed
feat: get rid of seismic-trie fork#328samlaf wants to merge 4 commits intoveridise-audit-feb-2026from
samlaf wants to merge 4 commits intoveridise-audit-feb-2026from
Conversation
samlaf
commented
Mar 5, 2026
Comment on lines
-315
to
-319
| // If we had the same state root calculation as ethereum when all values are public: | ||
| /* | ||
| hex!("b464525710cafcf5d4044ac85b72c08b1e76231b8d91f288fe438cc41d8eaafd") | ||
| */ | ||
| hex!("64f7822621afd8a66d71e233b48e945c101ab97334e19398422f22c3fae72223") |
Contributor
Author
There was a problem hiding this comment.
Note that we now do have the same state root as ethereum when storage only contains public slots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
Depends on:
These PRs implement a migration away from our seismic-trie fork and back to using stock alloy-trie, by changing the way we RLP encode FlaggedStorage slots.
See design in https://hackmd.io/ZOGfcUP2SyKmPeOuz0tmvg
Diff with upstream
this branch vs main (upstream)
seismic branch vs main branch